Repository navigation
fix(player): honor runtime discovery and source in embeds - #5244
Open
user-github-me wants to merge 1 commit into
Open
user-github-me wants to merge 1 commit into
user-github-me wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4002
Fixes #4003
A
srcembed can mistake the sharedwindow.__hfshader namespace for the runtime bridge. On current main it can reportreadyfrom document metadata while seeking leaves the authored timeline at zero; nested scenes can remain unmounted. Check the actual__playerbridge so standalone timelines remain driveable and nested scenes receive the runtime.Use the existing validated
runtime-srcresolver for probe injection as well assrcdoc. A blocked or missing runtime now emits a load error with its URL, stops probing, and marks that document failed. Detach the error handler when stopping or restarting so an old script cannot fail the next document. Same-origin/loopback validation and pinned-CDN fallback stay intact.Follows the scope described in unmerged #4246, with before/after captures and additional failure/recovery coverage.
Before
Main at
188475aaf: CDN access blocked; every embed hasruntime-src="/local-runtime.js"and receivesseek(1). The shader namespace leaves its marker at x=40 instead of x=200. Nested scenes stay empty, and the plain nested embed fetches jsDelivr and times out.After
Identical fixture HTML, same blocked-CDN policy. All four embeds load and seek to x=200; nested scenes use
/local-runtime.js, expose__player, and register their child timelines. No CDN requests or browser runtime errors.Validation
runtime-srcrecovers and seeks correctly.