Repository navigation
fix(sdk): decode scoped IDs when replaying patches - #5243
Merged
jrusso1020 merged 1 commit intoOct 8, 2026
Merged
Conversation
jrusso1020
approved these changes
Oct 8, 2026
jrusso1020
left a comment
Collaborator
There was a problem hiding this comment.
Verified: patch paths escape scoped IDs as JSON Pointer (hf-host~1hf-leaf), but the replay parser hands the escaped segment straight to findById. So replay, saved overrides and batch rollback all miss nested elements. Decoding once, in RFC 6902 order, before resolving is correct and leaves the patch format unchanged. Optional nit: this duplicates decodePathSegment in patches.ts, which could be exported and reused. The tests cover every element patch kind and check that the same-ID sibling stays untouched.
— Rames
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An SDK edit to
hf-host/hf-leafemits a JSON Pointer such as/elements/hf-host~1hf-leaf/text. The patch reader passes that encoded segment to the scoped DOM resolver, so replay, saved overrides, and iframe synchronization lose the edit. Decode element IDs once, in JSON Pointer order, before resolving the target.The patch format stays the same. Style, text, attribute, timing, hold, and removal patches now replay against the same nested element that the forward edit changed, including literal
~1IDs.Validation:
~1ID.