Repository navigation
docs(skills): preserve glyphs in text reveal masks - #5241
Merged
jrusso1020 merged 1 commit intoOct 8, 2026
Merged
Conversation
jrusso1020
approved these changes
Oct 8, 2026
jrusso1020
left a comment
Collaborator
There was a problem hiding this comment.
Useful guidance. A tight display line-height with an overflow: hidden mask does clip descenders and accents at rest, and the allow-overflow attribute waives the resting state too, so check alone won't catch it. Padding with a compensating margin is a sound approach, and the reminder to keep the parked line outside the enlarged mask is the right caveat. Another open skills docs change also updates the hyperframes-animation manifest hash, so whichever lands second will need a regenerate.
— Rames
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tight
line-heightwith anoverflow: hiddentext mask can cut descenders and accents after a reveal has finished. Document mask padding with a compensating negative margin, explain why the mask must use the text's font size foremunits, and link the guidance from themask-reveal-upadapter.Also describe releasing clipping on the timeline after the entrance and explain that
data-layout-allow-overflowsuppresses resting-state checks. Regenerate the skills manifest.Refs #5231. This addresses the requested skills guidance; the reported audit behavior remains for a separate change.
Validation:
Betreuung,Ägypj, andÉpýjat two settled timestamps. The unpadded mask lost 1,048–3,211 visible pixels; padding preserved the complete image byte-for-byte and kept the original text position. The initial parked text remained hidden.hyperframes lintandhyperframes check --strict --at 1.2,1.8, confirming the current audit blind spot.