Repository navigation
fix(cli): route timeline project directories to inspection - #5240
Merged
jrusso1020 merged 1 commit intoOct 8, 2026
Merged
jrusso1020 merged 1 commit into
jrusso1020 merged 1 commit into
Conversation
jrusso1020
approved these changes
Oct 8, 2026
jrusso1020
left a comment
Collaborator
There was a problem hiding this comment.
Thanks. This restores the documented hyperframes timeline <project-dir> form, which currently fails with "Unknown command" for any path. Flag validation and extra-argument checks still apply to inspection, and the -- handling for directories named like a verb is covered. One small trade-off: a mistyped verb now reports unexpected extra arguments rather than an unknown command. Heads up: this conflicts with #5279 in the timeline e2e test file, so whichever lands second needs a rebase.
— Rames
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documented
hyperframes timeline <project-dir>command rejects every project path as an unknown subcommand after timeline editing subcommands were added. Users cannot inspect another project by its advertised positional directory argument.Distinguish inspection paths from the existing edit verbs before Citty dispatches. Keep flags parsed and validated, preserve
--for literal directory names and edit arguments, and reject extra inspection arguments through the existing diagnostic helper.Validation: five initial end-to-end regressions fail on main; final 131 related timeline, command-registration, and argument-validation tests pass. Seventeen built-CLI cases cover absolute/relative paths with spaces, flag order, current-directory inspection, subcommand/dash-prefixed directory names, separators, unknown flags, extra/missing directories, and unchanged edit plans. Repeated inspection output is stable and all input files remain unchanged. CLI build/typecheck, root lint, formatting, comment checks, and commit hooks passed.