Repository navigation
fix(cli): preserve speaker labels in WebVTT cue text - #5233
Merged
jrusso1020 merged 1 commit intoOct 8, 2026
Merged
Conversation
jrusso1020
approved these changes
Oct 8, 2026
jrusso1020
left a comment
Collaborator
There was a problem hiding this comment.
The uppercase-colon metadata strip runs over the whole file, so cue lines like ALICE: Hello are deleted and later cue ids shift. Dropping it is safe: header lines either sit in a block with no timing line or come before the --> line, and only lines after the timing line become cue text. The tests fail on main and pass here. This conflicts textually with #5223 on the same line, so whichever lands second should keep both the CRLF normalization and this removal.
— Rames
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing a valid WebVTT cue containing
ALICE: Hello theresilently drops that cue. The parser removes uppercase colon-prefixed lines throughout the file as metadata, so it also truncates multiline captions and changes later cue IDs.Remove the global metadata-line deletion. Header metadata already sits outside timed cue payloads and is ignored by the existing block parser. Add speaker-label and multiline regressions with an
X-TIMESTAMP-MAPheader, plus SRT/VTT round trips, preserving cue text, timing, and IDs.Validation:
188475aaf; all package builds and the 220 related tests passed again. The rebuilt CLI reproduction, CLI typecheck, repository lint, formatting, comment checks, and all commit hooks passed on that base.