Repository navigation
fix(cli): retain WebVTT timestamps before cue settings - #5224
Merged
jrusso1020 merged 1 commit intoOct 8, 2026
Merged
jrusso1020 merged 1 commit into
jrusso1020 merged 1 commit into
Conversation
jrusso1020
approved these changes
Oct 8, 2026
jrusso1020
left a comment
Collaborator
There was a problem hiding this comment.
Confirmed on main: a WebVTT cue with settings after the end time, like align:start, gets an end time of 0, because the whole tail is passed to the timestamp parser. Taking only the timestamp token fixes both the long and short forms and leaves SRT parsing alone. The new cases fail on main and pass with the change. Note that this conflicts textually with #5223 in the test file.
— Rames
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing WebVTT cues with settings such as
align:startorline:90%replaces their end timestamp with zero. For example,00:01.000 --> 00:03.500 align:startbecomes{ start: 1, end: 0 }and exports an SRT cue ending before it starts.Read the timestamp token before the whitespace-separated cue settings. Keep both supported timestamp forms and the existing plain-timestamp behavior.
Validation: