Repository navigation
fix(fonts): preserve quoted family names in rendering - #3853
Closed
jrusso1020 wants to merge 1 commit into
Closed
jrusso1020 wants to merge 1 commit into
jrusso1020 wants to merge 1 commit into
Conversation
Carry forward the quote-provenance fix identified in #2778 on current main. Preserve literal generic and function-shaped names through normalization, deterministic font collection, and distributed validation.
Collaborator
Author
|
Closing to prioritize demonstrated user impact. This fixes valid but unusual quoted font names; we have no identified customer failure requiring it. The more practical variable-resolution and lint issues remain tracked in #2778. We can revisit this focused patch if a real composition reproduces the need. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quoted CSS family names are literals:
"serif"names a font, whileserifis a generic keyword. Current rendering loses that distinction, inserts Inter ahead of authored literal names, rejects them in distributed plan validation, and skips fetching literal generic or"var(...)"names.Preserve quote information through the existing font-family splitter and custom-property resolution, then use it in normalization, deterministic injection, and plan validation. The existing unquoted generic guard remains covered. This follows the CSS Fonts specification.
Carries forward the quote-provenance portion of #2778 on current main. That PR stays open for its separate scoped custom-property, fallback, and lint parsing work; this change does not claim to replace those parts.
Validation: 74 focused producer tests pass, including regressions for CSS, inline styles, data attributes, root aliases, literal generic names, and function-shaped names. Producer typecheck, repository commit hooks, and independent adversarial review pass.