Repository navigation
Enforce function-level coverage risk in CI - #196
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3bf44b847b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Closes #193
Summary
Build and Testjob while preserving the full xcresult when Xcode tests failVerification
DEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer ./test.shwith a host-only compiler metadata wrapper: 451 tests passed, 0 failures; all smoke scripts passedpython3 -m unittest discover -s scripts/tests -p 'test_function_risk.py' -v: 28 tests passed, including malformed aggregate counts, unknown xccov symbols, nullable complexity exceptions, and failure artifactspython3 scripts/function-risk/measure.py --result <fresh-xcresult> --output <output>: passed with 841 scored functions and 0 unmatched declarationsCodexBarMac.app: 13,891 of 22,135 executable lines covered, 62.76%macos-26CI run: 13,958 of 22,135 executable lines covered, 63.06%; this exposed and now records the host-dependentLaunchAtLoginManager.init(defaults:)ceilinggit diff --check: passedDisposable regression proof
A temporary
if falsebranch inLaunchAtLoginManager.refreshFromSystem()raised its SwiftLint decision count from 8 to 9 and CRAP score from 72 to 90. The real collector exited 1 withBaseline risk increased. The temporary branch was then removed, and the clean collector passed.Residual risk
The six existing scores above 30 across local and CI environments are explicit ceilings with follow-up requirements in
FUNCTION-RISK.md.