New SDK request: Golang SDK for DropboxSign #313

Activity

1. jtreminio-dropbox commented on Oct 11, 2023

   

   jtreminio-dropbox

   on Oct 11, 2023

   Last edited by jtreminio-dropbox

   Contributor

   More actions

   Unfortunately one of the hacky fixes we were forced to add to our OpenAPI spec was setting all endpoints as application/json first, and multipart/form-data second (if needed).

   This is due to all the other generators creating completely different code depending on the request content type (multipart/form-data creating API methods where all arguments are listed, vs a single typed object).

   This does not appear to be the case for the Golang generator, but I don't see that it correctly switches to multipart/form-data when a file upload is detected.

   • Here is what we did to the Node files
   • Here is what we did to the PHP files

   We would need to apply the same logic to this new Golang SDK to consider it.

   edit: I'm not great with Golang, so apologies upfront if your PR already does the above!

   👍React with 👍1Reacted by Abhishek Das
2. abhishekdas29 commented on Oct 15, 2023

   

   abhishekdas29

   on Oct 15, 2023

   Author

   More actions

   @jtreminio-dropbox - So are you saying that the auto generated files were manually overwritten in the PHP and node sdk?
3. jtreminio-dropbox commented on Oct 16, 2023

   

   jtreminio-dropbox

   on Oct 16, 2023

   Last edited by jtreminio-dropbox

   Contributor

   More actions

   Yes, all of our currently supported SDKs had their mustache templates changed to support what I listed above. I only linked PHP and Node but we did this for all the other languages as well.