Fix Zeitwerk autoloading when ActionMailer is not present.#5731
Merged
Conversation
nashby
force-pushed
the
fix-without-mailer-load
branch
from
1b28cb1 to
e5049af
Compare
When ActionMailer is not defined we have empty app/mailers/devise/mailer.rb file and Zeitwerk doesn't like that and errors with ``` expected file app/mailers/devise/mailer.rb to define constant Devise::Mailer ``` The fix is to tell Zeitwerk to ignore that file if ActionMailer constant if not defined. I tried to write a spec for it but since specs are run in the same process it's hard to have two Rails applications where one of them has ActionMailer define and the seconds one doesn't.
nashby
force-pushed
the
fix-without-mailer-load
branch
from
e5049af to
af112a2
Compare
This was referenced Nov 25, 2024
thomasleese
added a commit
to NHSDigital/manage-vaccinations-in-schools
that referenced
this pull request
Feb 12, 2025
This removes various references to `ActionMailer` and the mailer classes since they are no longer being used as we're sending emails using the GOV.UK Notify API directly now (#2841). We can't remove the `ApplicationMailer` and stop requiring `action_mailer/railtie` until heartcombo/devise#5731 has been released.
|
Works as intended. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
ActionMaileris not defined we have emptyapp/mailers/devise/mailer.rbfile and Zeitwerk doesn't like that and errors withexpected file app/mailers/devise/mailer.rb to define constant Devise::MailerThe fix is to tell Zeitwerk to ignore that file if
ActionMailerconstant if not defined.I tried to write a spec for it but since specs are run in the same process it's hard to have two Rails applications where one of them has
ActionMailerdefine and the seconds one doesn't.closes #5140, #5485