Conversation
| }); | ||
| }, | ||
| error => { | ||
| console.error(error); |
There was a problem hiding this comment.
Do we want to show to the user that there is something wrong with fetching the current API version
please get back to us if this keeps happening. This can happen if the graphql engine api is down or is returning a 400. might help
| }, | ||
| error => { | ||
| console.error(error); | ||
| dispatch({ type: SET_LATEST_SERVER_VERSION_ERROR, data: null }); |
There was a problem hiding this comment.
Do we want to show to the user that there is something wrong with fetching the latest API version
please get back to us if this keeps happening. This can happen if the releases.hasura.io api is down or is returning a 400. might help
console/src/routes.js
Outdated
| onEnter={composeOnEnterHooks([ | ||
| requireSchema, | ||
| requireMigrationStatus, | ||
| requireServerVersion, |
There was a problem hiding this comment.
We need to move it inside the layout instead of onEnter because if if that hook doesn't succeed, then console will be down. We can leave it if this is the intended behaviour.
console/src/components/Main/Main.js
Outdated
| ); | ||
| if (isClosedBefore === 'true') { | ||
| isUpdateAvailable = false; | ||
| this.state.showBannerNotification = false; |
There was a problem hiding this comment.
Change it to this.setState instead
|
Review app available at: https://hge-ci-pull-215.herokuapp.com |
v0.15 custom services
GitOrigin-RevId: e0668ae1122d72776c4f091e3bd9d43f3db852cc
4 participants
Adds update checker for a new version of server.
Things to test out for