Skip to content

fix(build): allow user-supplied binaries#540

Merged
harrisoncramer merged 1 commit intodevelopfrom
fix/server-build-issues
Apr 18, 2026
Merged

fix(build): allow user-supplied binaries#540
harrisoncramer merged 1 commit intodevelopfrom
fix/server-build-issues

Conversation

@harrisoncramer
Copy link
Copy Markdown
Owner

@harrisoncramer harrisoncramer commented Apr 18, 2026

Fixes three issues introduced in #528:

  • build_and_start would shut down the server permanently when a user provides their own binary via server.binary. The version check would detect a mismatch (especially in
    Nix where there's no .git dir), call shutdown(), then try build(true) which returns nil for user-provided binaries, leaving the server dead. Fixed by skipping the version check cycle entirely for user-provided binaries.
  • build() returned nil instead of false when a user-provided binary path doesn't exist, so build_and_start would proceed to start a non-existent binary. Now returns false, and build_and_start checks for it.
  • The Windows .exe extension was dropped when the binary name changed from bin to server. Restored platform-aware naming.

@harrisoncramer harrisoncramer merged commit f867aa7 into develop Apr 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant