fix: use pagination to list MR discussions#529
Merged
harrisoncramer merged 2 commits intoharrisoncramer:developfrom Mar 18, 2026
Merged
Conversation
This uses the gitlab.Scan function to iterate over all discussions and handle errors after the iterator is exhausted. The test for non-200s is no longer needed as the Scan function transforms such responses to standard errors.
jakubbortlik
commented
Feb 27, 2026
Comment on lines
-130
to
-140
| t.Run("Handles non-200s from Gitlab client", func(t *testing.T) { | ||
| request := makeRequest(t, http.MethodPost, "/mr/discussions/list", DiscussionsRequest{Blacklist: []string{}}) | ||
| svc := middleware( | ||
| discussionsListerService{testProjectData, fakeDiscussionsLister{testBase: testBase{status: http.StatusSeeOther}}}, | ||
| withMr(testProjectData, fakeMergeRequestLister{}), | ||
| withPayloadValidation(methodToPayload{http.MethodPost: newPayload[DiscussionsRequest]}), | ||
| withMethodCheck(http.MethodPost), | ||
| ) | ||
| data, _ := getFailData(t, svc, request) | ||
| checkNon200(t, data, "Could not list discussions", "/mr/discussions/list") | ||
| }) |
Collaborator
Author
There was a problem hiding this comment.
gitlab.Scan handles errors differently, i.e., it doesn't set a non-200 status code on the response, so this test is no longer valid.
harrisoncramer
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #182.
This uses the
gitlab.Scanfunction to iterate over all discussions and handle errors after the iterator is exhausted. The test for non-200s is no longer needed as the Scan function transforms such responses to standard errors.This PR also limits the number of API calls for emojis by only fetching emojis for the filtered discussions.
I've tested both fixes in a large MR and it correctly fetched all discussions (that were otherwise not fetched without the pagination) and emojis.