Harden stream processing close test#4263
Merged
Merged
Conversation
devinivy
approved these changes
Jun 21, 2021
devinivy
left a comment
devinivy
left a comment
Member
There was a problem hiding this comment.
That feels much better.
One thing I want to gut-check with you: do you believe that this test simulated bad/unexpected behavior from node's http server, and in turn it's not something critical to cover in node v14 and below? I see that this test has existed since the very early days of the framework, so perhaps it was more important when node was less stable/mature.
Contributor
Author
|
As I see it, the test validates that streams stop being processed when a request stops due to downstream / internal issues. My patch updates it so that it better does this with v16 (emitting Seem legit, but might be tested by some other case. Removing it does not change coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed the test to be compatible with node 16, which allows the
reqto be closed while the connection itself is still active.I also revised the stream, so we can really validate that the processing is stopped.
This is in response to #4262 (comment).