Add config flags.logLevel#113
Conversation
|
I've modified according to #114 |
phated
left a comment
phated
left a comment
There was a problem hiding this comment.
Nice and simple. 1 question about the appveyor changes.
| - nodejs_version: "6" | ||
|
|
||
| install: | ||
| - npm -g install npm@latest |
There was a problem hiding this comment.
Are we going to run into weird test runs on old node versions with this removed?
There was a problem hiding this comment.
@phated The reason of removing this line is that the latest npm don’t support old versions of nodejs (< v4.x). This is needed if we are going to support gulp-cli on these old versions and use Appveyor for test on Windows.
Or we might be able to skip test on Windows about old versions of nodejs.
There was a problem hiding this comment.
Not dropping 0.10.
Just install npm at a good version, like 2
There was a problem hiding this comment.
@phated If the “weird test” means using gulp-test-tool, since this tool is a thing to solve this issue on nodejs v0.10 on Windows, we can remove this tool if we skip test on Windows about old versions of nodejs.
There was a problem hiding this comment.
My reply crossed with yours.
Just install npm at a good version, like 2
I got it. I checked our test succeeded with npm@2 now.
|
@phated Thanks for merging. |
2 participants
I implemented for the issue #110.
Since Appveyor failed, I modified
appveyor.yml, too.