Add batching params #260
Merged
Merged
Conversation
Nabellaleen
reviewed
Jan 25, 2020
Collaborator
Nabellaleen
left a comment
Nabellaleen
left a comment
There was a problem hiding this comment.
I've copy the comments I've done on your fork PR, to be able to follow easily the answers here ;)
| resolver = get_custom_resolver(obj_type, orm_field_name) | ||
| if resolver is None: | ||
| resolver = get_batch_resolver(relationship_prop) if batching_ else \ | ||
| get_attr_resolver(obj_type, relationship_prop.key) |
Collaborator
There was a problem hiding this comment.
Suggested change
| get_attr_resolver(obj_type, relationship_prop.key) | |
| elif resolver is None: | |
| resolver = get_attr_resolver(obj_type, relationship_prop.key) |
katy-sadowski
previously approved these changes
Jan 27, 2020
katy-sadowski
left a comment
katy-sadowski
left a comment
There was a problem hiding this comment.
This is a test to check approve rights.
Collaborator
Author
|
@Nabellaleen Ignore @katy-sadowski approval - I asked her to do this so I can tests different permission settings. |
Nabellaleen
previously approved these changes
Jan 29, 2020
|
Was the default batching true or false? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add parameters to toggle
batchingon or off. This can be configured at 2 levels:SQLAlchemyObjectType.meta.batchingORMfield.batching. This trumpsSQLAlchemyObjectType.meta.batching.