Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

maxDepthQuery configuration is not enforced on 12.0.0 #757

Open

Description

@lhcopetti

I am playing with graphql lately and I was trying to mimic an attack where a recursive query is sent by the client to the GraphQL server and it seems like the latest version doesn’t enforce the maxDepthQuery restriction while v11.1.0 works perfectly fine, aborting the execution with a descriptive error:

{
    "errors": [
        {
            "message": "maximum query depth exceeded 18 > 3",
            "extensions": {
                "classification": "ExecutionAborted"
            }
        }
    ],
    "data": null
}

From comparing the dependency:tree’s from my test project, I found that v11.1.0 pulls the spring-boot-starter-actuator on the classpath, while v12.0.0 doesn’t. This may explain why the MaxQueryDepthInstrumentation is not instantiated because the GraphQLInstrumentationAutoConfiguration actually requires MetricsAutoConfiguration to be on the classpath:

Adding the spring-boot-starter-actuator dependency manually to my test spring-boot project with v12.0.0 resolves the issue.

Activity

  1. oliemansm commented on Dec 3, 2021

    @oliemansm
    Member

    v12 indeed has a breaking change that you now need to specify certain dependencies to use instead of pulling in all sorts of deps that you might not use.

  2. lhcopetti commented on Dec 4, 2021

    @lhcopetti
    Author

    What strikes me as odd is the fact that the functionality to prevent cyclic queries is conditional on having the actuator dependency. Is this by design or is there actually some concrete dependency on the actuator for the depth check to run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions