Reject bool for Cache timeout and expire - #376
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
bool subclasses int, so timeout=True became a 1s SQLite timeout and expire=True/False became a 1s TTL or immediate expiry (now+0). Raise TypeError for bool so callers pass an explicit numeric value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
boolsubclassesint, so:Cache(..., timeout=True)silently became a 1s SQLite timeoutcache.set/add/touch(..., expire=True)silently became a 1s TTLexpire=Falsebecamenow + 0(immediate expiry)This raises
TypeErrorwhen aboolis passed fortimeout/expire, while still accepting numeric values.Test plan
tests/test_bool_expire_timeout.py(9 passed)expire=5/touch(..., expire=10)still work