Merged
Conversation
Contributor
academo
approved these changes
Nov 5, 2024
Collaborator
|
Some interesting things in node 22:
|
tolzhabayev
approved these changes
Nov 7, 2024
Contributor
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Node 22 is now LTS. This PR adds support for Node 22 in plugin-e2e (and removes the upper bound) and changes the node engine in scaffolded plugins to 22. Also changing all workflows (local and scaffolded) to use 22.
We'll remove support for node 18 entirely once it's moved out of maintenance LTS.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Will add a follow up PR that bumps node version in the examples repo.
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/create-plugin@5.9.0-canary.1298.08bf9c9.0 npm install @grafana/plugin-e2e@1.12.0-canary.1298.08bf9c9.0 # or yarn add @grafana/create-plugin@5.9.0-canary.1298.08bf9c9.0 yarn add @grafana/plugin-e2e@1.12.0-canary.1298.08bf9c9.0