Test uninitialized queries in unsubmitted command buffers#4624
Open
greggman wants to merge 1 commit intogpuweb:mainfrom
Open
Test uninitialized queries in unsubmitted command buffers#4624greggman wants to merge 1 commit intogpuweb:mainfrom
greggman wants to merge 1 commit intogpuweb:mainfrom
Conversation
Query slots that have never been used at required to resolve to zero. Some implementaitons might wrongly mark them as used at encoding time instead of submit time.
|
Results for build job (at 702ebb4): +webgpu:api,operation,command_buffer,queries,occlusionQuery:occlusion_query,unsubmitted_render_pass:* - 1 cases, 1 subcases (~1/case)
+webgpu:api,operation,command_buffer,queries,timestampQuery:resolve_unused_slots:* - 2 cases, 2 subcases (~1/case)
-TOTAL: 280761 cases, 2322100 subcases
+TOTAL: 280764 cases, 2322103 subcases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Query slots that have never been used at required to resolve to zero. Some implementations might wrongly mark them as used at encoding time instead of submit time.
These pass on some implementations but it could be by luck of the just happen to be zero
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.