Improve responsive UI shell behavior - #1024
Open
sametcn99 wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1024 +/- ##
=======================================
Coverage 74.53% 74.53%
=======================================
Files 66 66
Lines 3483 3483
=======================================
Hits 2596 2596
Misses 688 688
Partials 199 199 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve the UI shell so navigation, connection errors, and scroll controls behave predictably across desktop, tablet, and mobile viewports.
The previous responsive layout allowed the permanent drawer to overlap main content at tablet widths, the temporary drawer required a dedicated close button, long connection errors could disturb header/content placement, and the scroll-to-top button could remain visible after returning to the top of the page.
Changes
Responsive navigation layout
smand larger breakpoints, preventing navigation from overlaying the page at tablet and desktop widths.Mobile drawer interactions
Connection error layout
Scroll-to-top behavior
TypeScript configuration
Validation
yarn --cwd ui lintyarn --cwd ui buildBoth commands complete successfully. The production build still reports the existing MUI barrel-module and bundle-size warnings.