Repository navigation
feat: add Expo config plugin - #709
Merged
Merged
Conversation
jokerttu
force-pushed
the
expo-config-plugin
branch
from
November 6, 2026 05:14
aa7c152 to
05edcd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an Expo config plugin, so Expo apps that generate their native projects with
npx expo prebuildget the native setup the Navigation SDK needs, and anEXPO.mdsetup guide linked from the README. It builds on @kota113's work in #577, whose commit is kept with their authorship.The plugin:
import GoogleMapstoAppDelegate.swiftand passes theInfo.plistGMSApiKeyvalue, which Expo writes fromios.config.googleMapsApiKey, toGMSServices.provideAPIKeyat launch.desugar_jdk_libs_nio:2.1.5). The API key comes from Expo'sandroid.config.googleMaps.apiKey.npx expo prebuildwith a clear error when an API key is missing orAppDelegate.swiftcannot be updated. Reading the app config never fails, so native builds work without the key environment variables.The plugin's file changes are unit-tested with Node's built-in test runner (
yarn test), which CI'stestjob now runs.Verified by following
EXPO.mdin a newcreate-expo-appdefault-template app (Expo SDK 58, React Native 0.88.1, expo-router 58.0.30):npx expo prebuild --clean,npx expo run:ios(iPhone 16 simulator, iOS 18.6), andnpx expo run:android(emulator) succeed. On both platforms the map renders andinit()returnsok.onLocationChangedreports a simulated location,setDestinationsreturnsOK, and guidance follows the simulated route. This route flow was not run on Android.Fixes #576
When squash-merging, keep @kota113's credit by adding this line to the commit body:
Pre-launch Checklist