Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

Move bucket_bound_hostname code into helper #121

Closed
#137
Closed
Move bucket_bound_hostname code into helper#121
#137
Assignees
IlyaFaer
Labels
api: storageIssues related to the googleapis/python-storage API.type: cleanupAn internal cleanup or hygiene concern.

Description

@IlyaFaer
IlyaFaer
opened on Apr 29, 2020

For now we have three places in which we're using bucket_bound_hostname. The code is almost the same in all three places, so it'll be good to union it in single helper:

python-storage/google/cloud/storage/blob.py

Lines 517 to 522 in 616f107

if ":" in bucket_bound_hostname:
api_access_endpoint = bucket_bound_hostname
else:
api_access_endpoint = "{scheme}://{bucket_bound_hostname}".format(
scheme=scheme, bucket_bound_hostname=bucket_bound_hostname
)

python-storage/google/cloud/storage/bucket.py

Lines 2531 to 2536 in 616f107

if ":" in bucket_bound_hostname:
api_access_endpoint = bucket_bound_hostname
else:
api_access_endpoint = "{scheme}://{bucket_bound_hostname}".format(
scheme=scheme, bucket_bound_hostname=bucket_bound_hostname
)

python-storage/google/cloud/storage/client.py

Lines 1014 to 1020 in 616f107

if ":" in bucket_bound_hostname: # URL includes scheme
url = bucket_bound_hostname
else: # scheme is given separately
url = "{scheme}://{host}/".format(
scheme=scheme, host=bucket_bound_hostname
)

Activity

  1. IlyaFaer
    added
    api: storageIssues related to the googleapis/python-storage API.
    type: cleanupAn internal cleanup or hygiene concern.
    on Apr 29, 2020
  2. IlyaFaer
    self-assigned this
    on Apr 29, 2020

  3. frankyn commented on Apr 29, 2020

    @frankyn
    frankyn
    on Apr 29, 2020
    Contributor

    that sounds good, thanks for catching the improvement.

  4. gcf-merge-on-green
    closed this as completedin #137on May 28, 2020
  5. gcf-merge-on-green
    added a commit that references this issue on May 28, 2020

    feat: add helper for bucket bound hostname URLs (#137)

    b26f9fa
  6. cojenco
    added 2 commits that reference this issue on Oct 13, 2021

    feat: add helper for bucket bound hostname URLs (googleapis#137)

    53e826d

    feat: add helper for bucket bound hostname URLs (googleapis#137)

    aeb2fa0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: storageIssues related to the googleapis/python-storage API.type: cleanupAn internal cleanup or hygiene concern.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions