feat: Added matching engine integration#995
Merged
Merged
Conversation
5b0b460 to
b45842b
Compare
2e2f144 to
6cfc93d
Compare
ReneeZhuGG
reviewed
Feb 17, 2022
b069195 to
f83d533
Compare
ivanmkc
commented
Feb 22, 2022
ReneeZhuGG
approved these changes
Feb 23, 2022
morgandu
suggested changes
Feb 23, 2022
| "index_endpoint", "undeployed", self | ||
| ) | ||
|
|
||
| def undeploy_all(self, sync: bool = True) -> "MatchingEngineIndexEndpoint": |
Contributor
Author
There was a problem hiding this comment.
Endpoint.undeploy_all doesn't have it so I followed that.
This loops through each. deployed_index and undeploys it.
Do you propose sending the same metadata for every deploy call?
Contributor
|
Thanks for the great work @ivanmkc , left some comments, mostly minor issue, except one pattern on the resource operation assuming resource is successfully created. Since the resource creation is |
f117cb5 to
e621402
Compare
morgandu
suggested changes
Feb 25, 2022
53e32da to
d6d8af3
Compare
morgandu
approved these changes
Feb 25, 2022
63f84be to
c4fb6a2
Compare
01cfdfa to
5b34124
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added matching engine integration.
Tasks
Testing
Potential convenience methods
Note
MatchingEngineIndexEndpoint.matchcould not be unit tested due to https://stackoverflow.com/questions/47202355/pytest-cannot-mock-init-of-my-class.It's been tested in the integration test.
Fixes b/201313324, #994