Skip to content

chore: Fix type error in _get_default_prompt_template for optional .values #6996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jul 16, 2026
+8 −8
Merged

chore: Fix type error in _get_default_prompt_template for optional .values #6996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions agentplatform/_genai/_evals_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,10 +484,10 @@ def _get_default_prompt_template(
and eval_item.evaluation_request.prompt
and eval_item.evaluation_request.prompt.prompt_template_data
):
if (
"prompt"
in eval_item.evaluation_request.prompt.prompt_template_data.values
):
template_values = (
eval_item.evaluation_request.prompt.prompt_template_data.values
)
if template_values and "prompt" in template_values:
return "{prompt}"
except Exception as e:
logger.warning("Failed to get prompt template from evaluation set: %s", e)
Expand Down
8 changes: 4 additions & 4 deletions vertexai/_genai/_evals_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,10 +469,10 @@ def _get_default_prompt_template(
and eval_item.evaluation_request.prompt
and eval_item.evaluation_request.prompt.prompt_template_data
):
if (
"prompt"
in eval_item.evaluation_request.prompt.prompt_template_data.values
):
template_values = (
eval_item.evaluation_request.prompt.prompt_template_data.values
)
if template_values and "prompt" in template_values:
return "{prompt}"
except Exception as e:
logger.warning("Failed to get prompt template from evaluation set: %s", e)
Expand Down
Loading