Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

test: add test to ensure that feature flags are sent during a ping and warm rpc #2425

Merged
gcf-merge-on-green merged 3 commits into from
Dec 3, 2024
Merged

test: add test to ensure that feature flags are sent during a ping and warm rpc #2425

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2826d63
test: add test to ensure that feature flags are sent during a ping an…
igorbernstein2 Nov 19, 2024
66032b9
add test for a few more feature flags
igorbernstein2 Nov 20, 2024
ae99047
csm is disabled in tests
igorbernstein2 Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions ...gtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@
import com.google.cloud.bigtable.data.v2.models.sql.Statement;
import com.google.cloud.bigtable.data.v2.stub.sql.ExecuteQueryCallable;
import com.google.cloud.bigtable.data.v2.stub.sql.SqlServerStream;
import com.google.common.base.Preconditions;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.Queues;
import com.google.common.io.BaseEncoding;
Expand Down Expand Up @@ -291,6 +292,28 @@ public void testFeatureFlags() throws InterruptedException, IOException, Executi
assertThat(featureFlags.getLastScannedRowResponses()).isTrue();
}

@Test
public void testPingAndWarmFeatureFlags()
throws InterruptedException, IOException, ExecutionException {
EnhancedBigtableStubSettings settings =
defaultSettings.toBuilder().setRefreshingChannel(true).build();
try (EnhancedBigtableStub ignored = EnhancedBigtableStub.create(settings)) {
Preconditions.checkState(
!fakeDataService.pingRequests.isEmpty(), "Ping request was not sent during setup");
Metadata metadata = metadataInterceptor.headers.take();

String encodedFeatureFlags =
metadata.get(Key.of("bigtable-features", Metadata.ASCII_STRING_MARSHALLER));
FeatureFlags featureFlags =
FeatureFlags.parseFrom(BaseEncoding.base64Url().decode(encodedFeatureFlags));

assertThat(featureFlags.getReverseScans()).isTrue();
assertThat(featureFlags.getLastScannedRowResponses()).isTrue();
Comment thread
igorbernstein2 marked this conversation as resolved.
assertThat(featureFlags.getRoutingCookie()).isTrue();
assertThat(featureFlags.getRetryInfo()).isTrue();
}
}

@Test
public void testCheckAndMutateRequestResponseConversion()
throws ExecutionException, InterruptedException {
Expand Down