Repository navigation
chore(compute-v1): stop FirewallsSmokeTest teardown flakes with GCE Enforcer - #36719
Open
torreypayne wants to merge 1 commit into
Open
torreypayne wants to merge 1 commit into
torreypayne wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register the firewall name for teardown immediately after
insert(before waiting on the operation) and ignore expected GCE Enforcer deletion conflicts during cleanup.In
helical-zone-771, GCE Enforcer removes API-created firewall rules shortly after creation regardless ofsource_ranges. That causedFirewallsSmokeTest#teardownto fail withGoogle::Cloud::InvalidArgumentError("is not ready") when itsdeleteoverlapped the enforcer's, or to skip cleanup if@client_ops.waitraised first.source_rangesunchanged (GCE Enforcer deletes non-GKE/non-AEF ingress rules regardless of range).NotFoundErrorandInvalidArgumentErrormatching"is not ready", re-raising everything else.helical-zone-771(FirewallsSmokeTest+ simulated concurrent delete race) and unit tests on Ruby 3.2 and 4.0.Tracking bug: http://b/568798581