Skip to content

Fix external links in navigation bar#420

Merged
tseaver merged 1 commit into
googleapis:masterfrom
silvolu:fix-nav-links
Dec 16, 2014
Merged

Fix external links in navigation bar#420
tseaver merged 1 commit into
googleapis:masterfrom
silvolu:fix-nav-links

Conversation

@silvolu

@silvolu silvolu commented Dec 16, 2014

Copy link
Copy Markdown
Contributor

Fixes #417.

Comment thread docs/_templates/layout.html Outdated

This comment was marked as spam.

@tseaver

tseaver commented Dec 16, 2014

Copy link
Copy Markdown
Contributor

LGTM except for the copy-paste issue I noted.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling 54b0b46 on silvolu:fix-nav-links into 31799c3 on GoogleCloudPlatform:master.

@silvolu

silvolu commented Dec 16, 2014

Copy link
Copy Markdown
Contributor Author

Fixed and squashed, thanks!

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling 6e32a33 on silvolu:fix-nav-links into 31799c3 on GoogleCloudPlatform:master.

tseaver added a commit that referenced this pull request Dec 16, 2014
Fix external links in navigation bar
@tseaver
tseaver merged commit a36f603 into googleapis:master Dec 16, 2014
@tseaver

tseaver commented Dec 16, 2014

Copy link
Copy Markdown
Contributor

Another post-merge regression failure:

https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/44241396#L301

@silvolu

silvolu commented Dec 16, 2014

Copy link
Copy Markdown
Contributor Author

@tseaver the new failures are my fault because I wiped out the content of the test datastore, but the test that was failing in the previous run is now green.
I'll re-populate and re-run.

@tseaver

tseaver commented Dec 16, 2014

Copy link
Copy Markdown
Contributor

Ugh

@silvolu

silvolu commented Dec 16, 2014

Copy link
Copy Markdown
Contributor Author

And back to green.

@dhermes dhermes added the docs label Dec 31, 2015
lukesneeringer added a commit that referenced this pull request Oct 3, 2017
atulep pushed a commit that referenced this pull request Apr 3, 2023
Source-Link: googleapis/synthtool@1b9ad76
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9db98b055a7f8bd82351238ccaacfd3cda58cdf73012ab58b8da146368330021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Links are broken on left sidebar of docs

4 participants