fix(api-core): prevent overwriting explicit empty strings for optional request_id#17798
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates setup_request_id in requests.py to check if the request ID attribute is explicitly None rather than falsy when handling proto-plus or other objects. This ensures that an empty string is preserved and not overwritten with a new UUID. Corresponding unit tests have been added to verify this behavior. I have no feedback to provide as there are no review comments.
daniel-sanche
approved these changes
Jul 20, 2026
This was referenced Jul 20, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses code review feedback regarding how
is_proto3_optional=Truefields are treated:requests.py: Changed the checkif not getattr(...)toif getattr(...) is Nonefor proto-plus messages and other objects whenis_proto3_optional=True. This prevents overwriting an explicitly set empty string ("") with a generated UUID.test_requests.py: Added parameterized test cases foris_proto3_optional=Truewith explicit empty string values""to verify they are preserved and not overwritten.