Skip to content

feat: add value_bitmask_filter to the read API#16884

Open
mutianf wants to merge 3 commits intogoogleapis:mainfrom
mutianf:bigtable-proto
Open

feat: add value_bitmask_filter to the read API#16884
mutianf wants to merge 3 commits intogoogleapis:mainfrom
mutianf:bigtable-proto

Conversation

@mutianf
Copy link
Copy Markdown
Contributor

@mutianf mutianf commented Apr 30, 2026

Manually generate the bitmask filter proto to unblock critical proto generation.

@mutianf mutianf requested a review from a team as a code owner April 30, 2026 02:23
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the ValueBitmask feature to the Google Cloud Bigtable V2 client, adding the ValueBitmask message type and integrating it into row filters. The PR also includes extensive refactoring, such as import reordering and whitespace adjustments. Feedback was provided to separate these non-critical refactorings into a dedicated pull request to maintain focus and improve the review process.

I am having trouble creating individual review comments. Click here to see my feedback.

packages/google-cloud-bigtable/google/cloud/bigtable_v2/init.py (19)

medium

This pull request includes extensive non-critical refactoring, such as import reordering and whitespace adjustments. Please move these changes to a separate pull request to keep this one focused on the value_bitmask_filter feature and to simplify the review process.

References
  1. Defer non-critical refactoring or cleanup tasks to a separate pull request to maintain the focus and reviewability of the current one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant