chore: update googleapis and regenerate#16882
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request performs a significant update across several packages, including google-analytics-data, google-cloud-cloudsecuritycompliance, and google-cloud-compute. Key changes involve the introduction of new API methods such as run_report, get_metadata, and update_kms_key, along with the addition of new resource types like InstantSnapshotGroups and Control. Additionally, resource path support has been expanded to include project-level locations for various services. Feedback was provided regarding the removal of the -W flag in the google-analytics-data noxfile.py, advising that changes to shared configuration patterns should be applied consistently across all packages in a universal change rather than piecemeal.
| shutil.rmtree(os.path.join("docs", "_build"), ignore_errors=True) | ||
| session.run( | ||
| "sphinx-build", | ||
| "-W", # warnings as errors |
There was a problem hiding this comment.
Removing the -W flag, which treats Sphinx warnings as errors, constitutes a piecemeal change to a shared configuration pattern. Changes to shared configurations should be applied consistently across all relevant packages in a dedicated, universal change rather than in individual pull requests. Please reinstate this flag and address any underlying warnings directly to maintain documentation quality.
References
- Changes to shared configurations, like mypy flags, should be applied consistently across all relevant packages in a dedicated, universal change rather than piecemeal in individual pull requests.
There was a problem hiding this comment.
Thanks for pointing it out - it's intentional :)
noahdietz
force-pushed
the
librarianops-generateall-20260429T205121Z
branch
from
3b033d9 to
bc7ed61
Compare
2 participants
Update googleapis to the latest commit and regenerate all client libraries.