refactor(bigframes): Clean up project/credential resolution logic#16859
Open
TrevorBergeron wants to merge 6 commits intomainfrom
Open
refactor(bigframes): Clean up project/credential resolution logic#16859TrevorBergeron wants to merge 6 commits intomainfrom
TrevorBergeron wants to merge 6 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request centralizes the logic for determining the default Google Cloud project ID by introducing a new env configuration module and updating the ClientsProvider to require a project ID. The review feedback highlights critical NameError issues in the new get_default_project_id function and the _get_bqclient_and_project helper, where variables were incorrectly referenced. Additionally, there are suggestions to remove an unused import and add a missing newline at the end of the new configuration file to align with PEP 8 standards.
tswast
reviewed
Apr 29, 2026
| import google.auth.transport.requests | ||
| import pydata_google_auth | ||
|
|
||
| from typing import Optional |
TrevorBergeron
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕