Cleanup duplicated "credentials can not sign" error #3031

Activity

1. theacodes

   added

   auth

   hygiene

   on Feb 16, 2017
2. danoscarmike

   added

   priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.

   Status: Acknowledged

   type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

   api: core

   on Feb 28, 2017
3. lukesneeringer commented on Aug 11, 2017

   

   lukesneeringer

   on Aug 11, 2017

   Contributor

   More actions

   @jonparrott Is this still a thing?
4. theacodes commented on Aug 11, 2017

   

   theacodes

   on Aug 11, 2017

   ContributorAuthor

   More actions

   Good question - @dhermes is it?
5. dhermes commented on Aug 11, 2017

   

   dhermes

   on Aug 11, 2017

   Contributor

   More actions

   We still have duplicated code:

   $ git log -1 --pretty=%H
   d750a1394781dbe33679057c02233d2dfc2540e1
   $ git grep -n 'you need a private key to sign'
   storage/google/cloud/storage/_signing.py:51:        raise AttributeError('you need a private key to sign credentials.'
   storage/google/cloud/storage/bucket.py:1121:                'you need a private key to sign credentials.'
   

   Now that google.cloud.storage._signing exists, you could probably move the check from Bucket.generate_upload_policy() into the _signing module.
6. lukesneeringer commented on Aug 11, 2017

   

   lukesneeringer

   on Aug 11, 2017

   Last edited by lukesneeringer

   Contributor

   More actions

   Meta-comment: This is a really good example of an issue where a TODO in the code would have served a lot better than an issue does. The issue actually loses context.
7. lukesneeringer

   closed this as completedin #3794on Aug 11, 2017
8. JustinBeckwith

   assigned

   lukesneeringer

   on Feb 1, 2021