[post-migration] google-cloud-storage post-migration tasks

googleapis/python-storage was moved to https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-storage in PR #16192

OBE Ensure that the following changes make it into the release notes for the next release due to changes made to setup.py to align with the state of google-cloud-python:
- Python 3.8 was dropped
- The package now requires protobuf >= 4.25.8, < 8.0.0
Ensure that the presubmit called python-sdk-zb-system-test (gcs-aiml-clients-testing-101) is present and runs in google cloudbuild for google-cloud-python. (DONE, see PR #16581)
Ensure that the analogous presubmit for the zonal bucket system test is present and runs in google cloudbuild for python-docs-samples see PR #14022
Ensure that the snippets from the split repo are migrated to the python-docs-samples repo (DONE, see PR #13989).
Ensure that system tests as found in Kokoro System Tests run successfully (DONE, see PR #16578).

@parthea

Hi @parthea , @chalmerlowe

There's one more task, details in b/500990583

@chandra-siri

Hi @parthea , @chalmerlowe

There's one more task, details in b/500990583

I created a PR in python-docs-samples with a cloudbuild yaml config and a zonal bucket script.
I mirrored it off the files in google-cloud-python. I went in and changed paths where possible to align with the directory structure in python-docs-samples.

I do not know what other configs or permissions (i.e. in projects, storage buckets, etc) need to be updated to enable these tests, nor whether the config OR script need additional updates.

@chandra-siri @chingor13 Please advise.

test: adds storage to list of system tests to run (#16578)

I've unchecked Ensure that the presubmit called python-sdk-zb-system-test (gcs-aiml-clients-testing-101) is present and runs in google cloudbuild for google-cloud-python in #16487 (comment). The presubmit is broken. Someone from the GCS team will need to take a look at python-sdk-zb-system-test (gcs-aiml-clients-testing-101. The failure is Step #3 - "run-tests-and-delete-vm": ERROR: (gcloud.compute.ssh) FAILED_PRECONDITION: Login profile size exceeds 32 KiB. Delete profile values to make additional space.

I don't believe the cleanup-old-keys step is working

google-cloud-python/packages/google-cloud-storage/cloudbuild/zb-system-tests-cloudbuild.yaml

Lines 26 to 59 in daeb931

    
             - name: "gcr.io/google.com/cloudsdktool/cloud-sdk" 
        
               id: "cleanup-old-keys" 
        
               entrypoint: "bash" 
        
               args: 
        
                 - "-c" 
        
                 - | 
        
                   #!/bin/bash 
        
                   set -e 
        
                   echo "Fetching OS Login SSH keys..." 
        
                   echo "Removing all keys." 
        
                   echo "---------------------------------------------------------------------" 
        
                   FINGERPRINTS_TO_DELETE=$$(gcloud compute os-login ssh-keys list \ 
        
                     --format="value(fingerprint)") 
        
                   echo "Keys to delete: $$FINGERPRINTS_TO_DELETE" 
        
                   if [ -z "$$FINGERPRINTS_TO_DELETE" ]; then 
        
                     echo "No keys found to delete. Nothing to do." 
        
                     exit 0 
        
                   fi 
        
                   while IFS= read -r FINGERPRINT; do 
        
                     if [ -n "$$FINGERPRINT" ]; then 
        
                       echo "Deleting key with fingerprint: $$FINGERPRINT" 
        
                       gcloud compute os-login ssh-keys remove \ 
        
                         --key="$$FINGERPRINT" \ 
        
                         --quiet || true 
        
                     fi 
        
                   done <<< "$$FINGERPRINTS_TO_DELETE" 
        
                   echo "---------------------------------------------------------------------" 
        
                   echo "Cleanup complete."

Step #1 - "cleanup-old-keys": Keys to delete: 
Step #1 - "cleanup-old-keys": No keys found to delete. Nothing to do.

Since the check is broken, we will temporarily disable it and block releases until it is fixed

See #16487 (comment)

chore(librarian): enable generation for google-cloud-storage (#16803)

@parthea

Hi @parthea , @chalmerlowe

As part of post-migration tasks, there's only 1 pending item (based on this PR's description)

Ensure that the analogous presubmit for the zonal bucket system test is present and runs

This was fixed in #16986 , but looks like it's flaky due to os-login key accumulation and as per your comment

hence raised PR - #17171

which should solve these issues.

Once this PR is merged, Can we mark this as finish and unblock the releases for google-cloud-storage ?

@parthea

hi @parthea , @chalmerlowe #17171 is submitted !

chore(release): enable release of google-cloud-storage (#17201)

Navigation Menu

Repository navigation

[post-migration] google-cloud-storage post-migration tasks #16487

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	- name: "gcr.io/google.com/cloudsdktool/cloud-sdk"
	id: "cleanup-old-keys"
	entrypoint: "bash"
	args:
	- "-c"
	- \|
	#!/bin/bash
	set -e

	echo "Fetching OS Login SSH keys..."
	echo "Removing all keys."
	echo "---------------------------------------------------------------------"

	FINGERPRINTS_TO_DELETE=$$(gcloud compute os-login ssh-keys list \
	--format="value(fingerprint)")

	echo "Keys to delete: $$FINGERPRINTS_TO_DELETE"

	if [ -z "$$FINGERPRINTS_TO_DELETE" ]; then
	echo "No keys found to delete. Nothing to do."
	exit 0
	fi

	while IFS= read -r FINGERPRINT; do
	if [ -n "$$FINGERPRINT" ]; then
	echo "Deleting key with fingerprint: $$FINGERPRINT"
	gcloud compute os-login ssh-keys remove \
	--key="$$FINGERPRINT" \
	--quiet \|\| true
	fi
	done <<< "$$FINGERPRINTS_TO_DELETE"

	echo "---------------------------------------------------------------------"
	echo "Cleanup complete."

[post-migration] google-cloud-storage post-migration tasks #16487

Description

Activity

chandra-siri commented on Apr 9, 2026

chalmerlowe commented on Apr 9, 2026

parthea commented on Apr 24, 2026

chandra-siri commented on May 19, 2026

chandra-siri commented on May 19, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions