Skip to content

gcloud.storage.bucket.Bucket.upload_file defaults 'key' to None #137

Closed
Closed
gcloud.storage.bucket.Bucket.upload_file defaults 'key' to None#137
Assignees
tseaver
Labels
🚨This issue needs some love.api: storageIssues related to the Cloud Storage API.triage meI really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
Milestone
Storage Stable

Description

@tseaver
tseaver
opened on Sep 18, 2014

The API cannot do anything useful with the default: either it should be a required argument, or else the method should do something sensible if it is not passed. E.g., one might crack the last element of the filename off and use that as a default key.

Activity

  1. tseaver commented on Sep 22, 2014

    @tseaver
    tseaver
    on Sep 22, 2014
    ContributorAuthor

    The docstring actually requires the latter choice:

    https://github.com/GoogleCloudPlatform/gcloud-python/blob/1f2aaf3606802f4f02eeb30e22e1082ef7f4594e/gcloud/storage/bucket.py#L234

  2. tseaver
    added
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    api: storageIssues related to the Cloud Storage API.
    on Sep 22, 2014
  3. silvolu
    added this to the milestone on Sep 24, 2014
  4. tseaver
    closed this as completedin e6ad297on Sep 30, 2014
  5. silvolu
    added a commit that references this issue on Sep 30, 2014

    Merge pull request #191 from tseaver/137-upload_file-guess_key_based_…

    60887ab
  6. jgeewax
    added
    api: storageIssues related to the Cloud Storage API.
    and removed
    api: storageIssues related to the Cloud Storage API.
    on Jan 30, 2015
  7. jgeewax
    modified the milestones: , Storage Stable on Jan 30, 2015
  8. dhermes
    added a commit that references this issue on Jun 9, 2017

    Merge pull request googleapis#137 from jgeewax/koss-collection-5

    ad3431b
  9. yoshi-automation
    added
    triage meI really want to be triaged.
    🚨This issue needs some love.
    on Apr 7, 2020

  10. 93 remaining items

  11. parthea
    added 8 commits that reference this issue on Nov 24, 2025

    chore(deps): update dependency pytest to v6.2.4 (#137)

    f3e6511

    chore(python): disable dependency dashboard (#137)

    b17329b

    chore: release 2.1.1 (#137)

    0845511

    ci(python): run lint / unit tests / docs as GH actions (#137)

    a5ba6f4

    refactor: Refactor of hocr functions and fixing lost changes (#137)

    6acebab

    docs: omit mention of Python 2.7 in 'CONTRIBUTING.rst' (#1127) (#137)

    5680494

    chore: release 1.2.0 (#141)

    c92c40d

    Separate oauthlib integration into its own package (#137)

    e839bb3
  12. parthea
    added a commit that references this issue on Mar 2, 2026

    chore(deps): update pypa/cibuildwheel action to v2.8.0 (#137)

    e69893d
  13. parthea
    added 5 commits that reference this issue on Mar 9, 2026

    feat: support computed columns (#139)

    cb17398

    chore: release 1.0.0 (#167)

    9f78c53

    feat: add helper for bucket bound hostname URLs (#137)

    6ed927f

    docs: update samples dep to 'google-cloud-spanner==1.19.0' (#137)

    1677423

    chore: release 1.19.1 (#144)

    c59aeb2
  14. ohmayr
    added a commit that references this issue on Mar 31, 2026

    chore(deps): update pypa/cibuildwheel action to v2.8.0 (#137)

    85b377e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

🚨This issue needs some love.api: storageIssues related to the Cloud Storage API.triage meI really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions