You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This change introduces client-generated Job IDs. It also adds support for user-specified job prefixes.
The goal of this feature is to make inserting jobs idempotent. I am concerned that I may not have quite captured that in this pull request. Job IDs are generated when BigQueryClient::runQueryAsJob() or the various Job-creating methods on Table are called. This means that multiple calls to those methods will result in different unique Job IDs, even if the configuration is identical.Those IDs are accessible after the call is executed, by invoking Job::id(). Currently there is not a means for a user to manually specify a Job ID (only a prefix); this means that one cannot retry with an existing Job ID.
If this is an issue, it could be mitigated without major changes to the client by adding an optional $jobId argument to the various job-creating methods' $options, along with documentation advising against using it except in well-defined circumstances.
phpunit is getting hung up on a spanner unit test:
Starting test 'Google\Cloud\Tests\Unit\Spanner\Connection\GrpcTest::testCallBasicMethods with data set #0 ('listInstanceConfigs', array('projects/my-project'), array('projects/my-project', array(array(array('projects/my-project')))))'.
I'm investigating now!
jdpedrie
added
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
and removed
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
labels
Aug 8, 2017
👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.
😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.
Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.
googlebot
added
cla: no
This human has *not* signed the Contributor License Agreement.
and removed
cla: yes
This human has signed the Contributor License Agreement.
labels
Aug 10, 2017
googlebot
added
cla: yes
This human has signed the Contributor License Agreement.
and removed
cla: no
This human has *not* signed the Contributor License Agreement.
labels
Aug 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces client-generated Job IDs. It also adds support for user-specified job prefixes.
The goal of this feature is to make inserting jobs idempotent. I am concerned that I may not have quite captured that in this pull request. Job IDs are generated when
BigQueryClient::runQueryAsJob()or the various Job-creating methods onTableare called. This means that multiple calls to those methods will result in different unique Job IDs, even if the configuration is identical.Those IDs are accessible after the call is executed, by invokingJob::id(). Currently there is not a means for a user to manually specify a Job ID (only a prefix); this means that one cannot retry with an existing Job ID.If this is an issue, it could be mitigated without major changes to the client by adding an optional
$jobIdargument to the various job-creating methods'$options, along with documentation advising against using it except in well-defined circumstances.