Skip to content

BigQuery.getQueryResults no longer returns null on a 404#2469

Merged
andreamlin merged 1 commit intogoogleapis:masterfrom
andreamlin:master
Sep 29, 2017
Merged

BigQuery.getQueryResults no longer returns null on a 404#2469
andreamlin merged 1 commit intogoogleapis:masterfrom
andreamlin:master

Conversation

@andreamlin
Copy link
Copy Markdown
Contributor

BigQuery.getQueryResults() returns a GetQueryResultsResponse, which should not be null even if a 404 was thrown. Returning a null results in BigQueryImpl.getQueryResults() throwing a NPE, which is less informative than a wrapped "Not Found" BigQueryException.

This is similar to the behavior of BigQuery.query(), which returns a QueryResponse, and just bubbles up any exceptions, translated, without filtering for any particular exception.

Resolves issue #2428.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 28, 2017
@garrettjonesgoogle garrettjonesgoogle requested review from vam-google and removed request for garrettjonesgoogle September 28, 2017 23:21
Copy link
Copy Markdown
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreamlin andreamlin merged commit 6983aa2 into googleapis:master Sep 29, 2017
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
🤖 I have created a release *beep* *boop*
---


## [3.5.0](https://togithub.com/googleapis/java-bigquerystorage/compare/v3.4.0...v3.5.0) (2024-04-26)


### Features

* Add `libraries_bom_version` in metadata ([#1956](https://togithub.com/googleapis/java-bigquerystorage/issues/1956)) ([#2463](https://togithub.com/googleapis/java-bigquerystorage/issues/2463)) ([b35bd4a](https://togithub.com/googleapis/java-bigquerystorage/commit/b35bd4a631ad6411531cd9056d01e829a0863b39))


### Bug Fixes

* **deps:** Update the Java code generator (gapic-generator-java) to 2.39.0 ([#2467](https://togithub.com/googleapis/java-bigquerystorage/issues/2467)) ([e2bc82d](https://togithub.com/googleapis/java-bigquerystorage/commit/e2bc82dde45c8c8e01bbe221f5817b02e9c5b7ed))


### Dependencies

* Update actions/checkout digest to 1d96c77 ([#2469](https://togithub.com/googleapis/java-bigquerystorage/issues/2469)) ([8efb813](https://togithub.com/googleapis/java-bigquerystorage/commit/8efb8131ff89b57509b4b122c75f765c62514b1c))
* Update arrow.version to v16 ([#2468](https://togithub.com/googleapis/java-bigquerystorage/issues/2468)) ([d143c65](https://togithub.com/googleapis/java-bigquerystorage/commit/d143c65b6c92b98d321408458a6b2bc18e42593b))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.38.2 ([#2453](https://togithub.com/googleapis/java-bigquerystorage/issues/2453)) ([a054ddd](https://togithub.com/googleapis/java-bigquerystorage/commit/a054dddb20962c610a7af5c8cd76c93082df55fa))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.39.0 ([#2473](https://togithub.com/googleapis/java-bigquerystorage/issues/2473)) ([4eadc4a](https://togithub.com/googleapis/java-bigquerystorage/commit/4eadc4a5e63acf2daba7589f804b5facad1452fa))
* Update dependency com.google.cloud:sdk-platform-java-config to v3.28.1 ([#2455](https://togithub.com/googleapis/java-bigquerystorage/issues/2455)) ([80269b0](https://togithub.com/googleapis/java-bigquerystorage/commit/80269b0f861ab9f5a2426668e10b35e963019395))
* Update dependency com.google.cloud:sdk-platform-java-config to v3.29.0 ([#2465](https://togithub.com/googleapis/java-bigquerystorage/issues/2465)) ([c082c36](https://togithub.com/googleapis/java-bigquerystorage/commit/c082c363fc365962dc9654a9cefb7602711c03f8))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this pull request Mar 30, 2026
* feat: Transfer Manager Parallel Composite Uploads Prework

* fix toString

* add differences to clirr

* clirr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants