Skip to content

Make Cloud Spanner Mutations serializable#1952

Merged
vkedia merged 6 commits intogoogleapis:masterfrom
mairbek:java-serialization
Apr 21, 2017
Merged

Make Cloud Spanner Mutations serializable#1952
vkedia merged 6 commits intogoogleapis:masterfrom
mairbek:java-serialization

Conversation

@mairbek
Copy link
Copy Markdown

@mairbek mairbek commented Apr 19, 2017

Same goal as #1939 but uses standard Java serialization and looks much cleaner.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 19, 2017
Merge branch 'master' of https://github.com/GoogleCloudPlatform/googl…
8e9cc00 
…e-cloud-java into java-serialization

# Conflicts:
#	google-cloud-core/src/main/java/com/google/cloud/Date.java
#	google-cloud-core/src/main/java/com/google/cloud/Timestamp.java
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 19, 2017

Coverage Status

Changes Unknown when pulling 8e9cc00 on mairbek:java-serialization into ** on GoogleCloudPlatform:master**.

vkedia
vkedia suggested changes Apr 20, 2017
View reviewed changes
Copy link
Copy Markdown

@vkedia vkedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add serialization tests for each of these classes that you made serializable.

Comment thread google-cloud-spanner/src/test/java/com/google/cloud/spanner/MutationTest.java Outdated
// Equality, not identity.
tester.addEqualityGroup(
Mutation.newInsertBuilder("T1").build(), Mutation.newInsertBuilder("T1").build());
Mutation.newInsertBuilder("T1").build(), Mutation.newInsertBuilder("T1").build());

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@vkedia
Copy link
Copy Markdown

vkedia commented Apr 20, 2017

Added @garrettjonesgoogle since you are touching some of the common classes.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 20, 2017

Coverage Status

Coverage increased (+0.03%) to 80.931% when pulling 140f6ab on mairbek:java-serialization into a722e95 on GoogleCloudPlatform:master.

@mairbek
Copy link
Copy Markdown
Author

mairbek commented Apr 20, 2017

Added more tests and restored formatting

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 20, 2017

Coverage Status

Coverage increased (+0.03%) to 80.931% when pulling 9f7d8af on mairbek:java-serialization into a722e95 on GoogleCloudPlatform:master.

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

garrettjonesgoogle commented Apr 21, 2017

The google-cloud-core changes look good.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 21, 2017

Coverage Status

Coverage decreased (-0.04%) to 80.86% when pulling 3534a49 on mairbek:java-serialization into a722e95 on GoogleCloudPlatform:master.

@vkedia vkedia merged commit 734a7c4 into googleapis:master Apr 21, 2017
@vkedia vkedia mentioned this pull request Apr 21, 2017
Closed
chingor13 pushed a commit that referenced this pull request Jan 22, 2026
@release-please
chore(main): release 2.31.5-SNAPSHOT (#1952)
5d1c262 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
@renovate-bot
chore(deps): update dependency com.google.cloud:google-cloud-bigquery…
065367f 
…storage to v2.30.0 (#1952)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-bigquerystorage](https://togithub.com/googleapis/java-bigquerystorage) | `2.28.2` -> `2.30.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquerystorage/2.30.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquerystorage/2.30.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquerystorage/2.30.0/compatibility-slim/2.28.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquerystorage/2.30.0/confidence-slim/2.28.2)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-bigquerystorage</summary>

### [`v2.30.0`](https://togithub.com/googleapis/java-bigquerystorage/blob/HEAD/CHANGELOG.md#&#8203;2300-httpsgithubcomgoogleapisjava-bigquerystoragecomparev2290v2300-2023-02-06)

[Compare Source](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.29.0...v2.30.0)

##### Features

-   Add userClose flag back to StreamWriter ([#&#8203;1973](https://togithub.com/googleapis/java-bigquerystorage/issues/1973)) ([4b51acd](https://togithub.com/googleapis/java-bigquerystorage/commit/4b51acd49292d99e1c3cd670bec695b8bcd3b5c4))

##### Bug Fixes

-   Close stream connection before each retry ([#&#8203;1975](https://togithub.com/googleapis/java-bigquerystorage/issues/1975)) ([54e9bb9](https://togithub.com/googleapis/java-bigquerystorage/commit/54e9bb9116eb9781b6f2266f98de4d3853a469b8))
-   Improve ConnectionWorker fine logging ([#&#8203;1972](https://togithub.com/googleapis/java-bigquerystorage/issues/1972)) ([812bcf1](https://togithub.com/googleapis/java-bigquerystorage/commit/812bcf16efdc7a1797435f0b87430c35f27f7245))

### [`v2.29.0`](https://togithub.com/googleapis/java-bigquerystorage/blob/HEAD/CHANGELOG.md#&#8203;2290-httpsgithubcomgoogleapisjava-bigquerystoragecomparev2284v2290-2023-02-01)

[Compare Source](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.28.4...v2.29.0)

##### Features

-   Add timeout to inflight queue waiting ([#&#8203;1957](https://togithub.com/googleapis/java-bigquerystorage/issues/1957)) ([3159b12](https://togithub.com/googleapis/java-bigquerystorage/commit/3159b120e5cd388cf9776a1fa928a3e6ae105d9d))
-   Allow java client to handle schema change during same stream name  ([#&#8203;1964](https://togithub.com/googleapis/java-bigquerystorage/issues/1964)) ([305f71e](https://togithub.com/googleapis/java-bigquerystorage/commit/305f71ee4b274df58388fc3000e9f5da9fc908e1))

##### Bug Fixes

-   At connection level, retry for internal errors ([#&#8203;1965](https://togithub.com/googleapis/java-bigquerystorage/issues/1965)) ([9c01bc1](https://togithub.com/googleapis/java-bigquerystorage/commit/9c01bc11b51dc1e3e209e4d6b666b9ddd3212cf5))
-   Reduce visibility of the ConnectionPool and ConnectionWorker, so… ([#&#8203;1954](https://togithub.com/googleapis/java-bigquerystorage/issues/1954)) ([dcb234b](https://togithub.com/googleapis/java-bigquerystorage/commit/dcb234b95d0812d4d91b0c206d0b7e0fb30ab0fa))
-   Remove unrecoverable connection from connection pool during multiplexing  ([#&#8203;1967](https://togithub.com/googleapis/java-bigquerystorage/issues/1967)) ([091dddb](https://togithub.com/googleapis/java-bigquerystorage/commit/091dddb9b2baf1f4b481e8d7961d451b71a8508b))

### [`v2.28.4`](https://togithub.com/googleapis/java-bigquerystorage/blob/HEAD/CHANGELOG.md#&#8203;2284-httpsgithubcomgoogleapisjava-bigquerystoragecomparev2283v2284-2023-01-25)

[Compare Source](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.28.3...v2.28.4)

##### Bug Fixes

-   Fix one potential root cause of deadlock in connection worker ([#&#8203;1955](https://togithub.com/googleapis/java-bigquerystorage/issues/1955)) ([598ce5e](https://togithub.com/googleapis/java-bigquerystorage/commit/598ce5eb5e8d5efaaa841495794be4d39c6c0fce))

### [`v2.28.3`](https://togithub.com/googleapis/java-bigquerystorage/blob/HEAD/CHANGELOG.md#&#8203;2283-httpsgithubcomgoogleapisjava-bigquerystoragecomparev2282v2283-2023-01-20)

[Compare Source](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.28.2...v2.28.3)

##### Bug Fixes

-   Fix deadlock issue in ConnectionWorkerPool ([#&#8203;1938](https://togithub.com/googleapis/java-bigquerystorage/issues/1938)) ([caf1e76](https://togithub.com/googleapis/java-bigquerystorage/commit/caf1e7603153b1b8de90d6294ac15c711076d8f4))
-   **java:** Skip fixing poms for special modules ([#&#8203;1744](https://togithub.com/googleapis/java-bigquerystorage/issues/1744)) ([#&#8203;1946](https://togithub.com/googleapis/java-bigquerystorage/issues/1946)) ([2863542](https://togithub.com/googleapis/java-bigquerystorage/commit/286354231eaf8e329bbea05e0c45b28e14f4a1e7))
-   Update BQTableSchemaToProtoDescriptor to unblock a protobuf change. ([#&#8203;1942](https://togithub.com/googleapis/java-bigquerystorage/issues/1942)) ([62cc80a](https://togithub.com/googleapis/java-bigquerystorage/commit/62cc80a216ff4969a30e5fe93ff74b2c582e4677))
-   We should isolate the client used in StreamWriter and the client used in ConnectionWorker ([#&#8203;1933](https://togithub.com/googleapis/java-bigquerystorage/issues/1933)) ([3530672](https://togithub.com/googleapis/java-bigquerystorage/commit/3530672f0bddfacb973fb0fc1d30aabb4ffefccb))

##### Dependencies

-   Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.1.2 ([#&#8203;1949](https://togithub.com/googleapis/java-bigquerystorage/issues/1949)) ([23ec7fa](https://togithub.com/googleapis/java-bigquerystorage/commit/23ec7fa2c70c720fb995bdfac9416a29d77de2e2))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-bigquerystorage).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45Ny42IiwidXBkYXRlZEluVmVyIjoiMzQuMTE0LjAifQ==-->
lqiu96 pushed a commit that referenced this pull request Mar 20, 2026
@release-please
chore(main): release 2.31.5-SNAPSHOT (#1952)
58822ab 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
@renovate-bot
deps: update dependency com.google.cloud:sdk-platform-java-config to …
70d8383 
…v3.45.1 (googleapis#1952)
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
@renovate-bot @gcf-owl-bot
build(deps): update dependency com.google.cloud:google-cloud-shared-c…
fc82382 
…onfig to v1.7.5 (#1952)

* build(deps): update dependency com.google.cloud:google-cloud-shared-config to v1.7.5

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
meltsufin pushed a commit that referenced this pull request May 1, 2026
@renovate-bot @gcf-owl-bot
build(deps): update dependency com.google.cloud:google-cloud-shared-c…
ecf9b48 
…onfig to v1.7.5 (#1952)

* build(deps): update dependency com.google.cloud:google-cloud-shared-config to v1.7.5

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garrettjonesgoogle garrettjonesgoogle Awaiting requested review from garrettjonesgoogle

1 more reviewer

@vkedia vkedia vkedia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mairbek @coveralls @vkedia @garrettjonesgoogle @googlebot