pubsub: make subscriber connections split requests properly by pongad · Pull Request #1675 · googleapis/google-cloud-java

pongad · 2017-03-01T05:53:07Z

coveralls · 2017-03-01T06:50:47Z

Changes Unknown when pulling 44ff37f on pongad:partition into ** on GoogleCloudPlatform:master**.

Sign in to view

+      <artifactId>truth</artifactId>
+      <version>0.30</version>
+      <scope>test</scope>
+    </dependency>


Sign in to view

        try {
          acksToSend = new ArrayList<>(pendingAcks);
-          logger.log(Level.INFO, "Sending {} acks", acksToSend.size());
+          logger.log(Level.INFO, "Sending " + acksToSend.size() + " acks");


Sign in to view

-      if (ackChunksIt.hasNext()) {
-        List<String> ackChunk = ackChunksIt.next();
-        requestBuilder.addAllAckIds(ackChunk);
+  @VisibleForTesting


Sign in to view

+    StreamingPullRequest.Builder[] requests =
+        partitionAckOperations(acksToSend, ackDeadlineExtensions, MAX_PER_REQUEST_CHANGES);
+    for (StreamingPullRequest.Builder request : requests) {
+      requestObserver.onNext(request.build());


Sign in to view

+    count = 0;
+    for (PendingModifyAckDeadline modify : ackDeadlineExtensions) {
+      for (String ackId : modify.ackIds) {
+        requests[count / size]


pongad · 2017-03-02T03:28:43Z

@garrettjonesgoogle PTAL

coveralls · 2017-03-02T04:42:27Z

Coverage increased (+0.09%) to 81.204% when pulling ad9dac4 on pongad:partition into a47d5a0 on GoogleCloudPlatform:master.

Sign in to view

+    List<StreamingPullRequest> requests = new ArrayList<>();
+    for (StreamingPullRequest req :
+        StreamingSubscriberConnection.partitionAckOperations(
+            acksToSend, ackDeadlineExtensions, size)) {


Sign in to view

+      numExtensions += modify.ackIds.size();
+    }
+    int numRequests = Math.max(numExtensions, acksToSend.size());
+    numRequests = numRequests / size + (numRequests % size == 0 ? 0 : 1);


Sign in to view

+            Arrays.asList("a", "b", "c"), Collections.<PendingModifyAckDeadline>emptyList(), 3);
+    Truth.assertThat(requests)
+        .contains(
+            StreamingPullRequest.newBuilder().addAckIds("a").addAckIds("b").addAckIds("c").build());


Sign in to view

+    requests =
+        partitionAckOperations(
+            Arrays.asList("a", "b", "c", "d"),
+            Arrays.asList(new PendingModifyAckDeadline(42, "A")),


garrettjonesgoogle · 2017-03-03T00:36:44Z

LGTM

coveralls · 2017-03-03T02:01:20Z

Coverage increased (+0.1%) to 81.215% when pulling 73b80f7 on pongad:partition into a47d5a0 on GoogleCloudPlatform:master.

…jdbc to v2.20.1 (googleapis#1675)

…is set (#1675) * docs: clarified where ordering_key will be written if write_metadata is set PiperOrigin-RevId: 551210991 Source-Link: googleapis/googleapis@7c762d7 Source-Link: https://github.com/googleapis/googleapis-gen/commit/15fe4c5ff5ebd52911b429b05b992e232f53351e Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTVmZTRjNWZmNWViZDUyOTExYjQyOWIwNWI5OTJlMjMyZjUzMzUxZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…is set (#1675) * docs: clarified where ordering_key will be written if write_metadata is set PiperOrigin-RevId: 551210991 Source-Link: googleapis/googleapis@7c762d7 Source-Link: https://github.com/googleapis/googleapis-gen/commit/15fe4c5ff5ebd52911b429b05b992e232f53351e Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTVmZTRjNWZmNWViZDUyOTExYjQyOWIwNWI5OTJlMjMyZjUzMzUxZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

pubsub: make subscriber connections split requests properly

44ff37f

Fixes #1624.

pongad requested a review from garrettjonesgoogle March 1, 2017 05:53

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 1, 2017

garrettjonesgoogle reviewed Mar 1, 2017

View reviewed changes

pr comment

ad9dac4

garrettjonesgoogle mentioned this pull request Mar 2, 2017

Publisher.setupDurationBasedPublishAlarm - log does not replace %d, potentially reduce log level #1682

Closed

garrettjonesgoogle reviewed Mar 2, 2017

View reviewed changes

pr comment

73b80f7

pongad merged commit c81077a into googleapis:master Mar 3, 2017

pongad deleted the partition branch March 3, 2017 02:28

chingor13 pushed a commit that referenced this pull request Jan 22, 2026

chore: mark the unmanaged dependency check required (#1675)

8146530

suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026

chore(deps): update dependency com.google.cloud:google-cloud-spanner-…

c064a54

…jdbc to v2.20.1 (googleapis#1675)

suztomo pushed a commit that referenced this pull request Mar 30, 2026

chore: add JDK 25 to ci (#1675)

e03306d

lqiu96 pushed a commit that referenced this pull request Apr 1, 2026

chore: add JDK 25 to ci (#1675)

65a5bcf

Conversation

pongad commented Mar 1, 2017

Uh oh!

coveralls commented Mar 1, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

pongad commented Mar 2, 2017

Uh oh!

coveralls commented Mar 2, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

garrettjonesgoogle commented Mar 3, 2017

Uh oh!

coveralls commented Mar 3, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants