add zone to GAE Flex logging enhancer by gregw · Pull Request #1589 · googleapis/google-cloud-java

gregw · 2017-02-03T02:39:27Z

The google stackdriver logging console requires that the zone label be set in the monitored resource before it can aggregate logs by trace ID.

coveralls · 2017-02-03T04:17:29Z

Coverage decreased (-0.04%) to 83.31% when pulling b7c062f on jetty-project:enhance-zone into 2fbb281 on GoogleCloudPlatform:master.

coveralls · 2017-02-03T04:19:56Z

Coverage decreased (-0.03%) to 83.315% when pulling b7c062f on jetty-project:enhance-zone into 2fbb281 on GoogleCloudPlatform:master.

meltsufin · 2017-02-06T19:40:37Z

@garrettjonesgoogle Can you please take a look?

garrettjonesgoogle · 2017-02-06T19:44:11Z

There is a release going out on Tuesday that I don't want to destabilize; I'll take a look after that goes out.

garrettjonesgoogle

BTW, someone pointed out that LoggingHandler.Enhancer is package-private. Could you make it public in this PR?

Sign in to view

+    try {
+      HttpURLConnection metadata = (HttpURLConnection) new URL(
+          "http://metadata.google.internal/computeMetadata/v1/instance/zone").openConnection();
+      metadata.setRequestProperty("Metadata-Flavor", "Google");


Handler initialization may now call user supplied code in enhancers during initialization and logging. This commit catches any exceptions thrown and uses the existing error reporting mechanism to log the exception the stderr. The GaeFlexEnhancer now separately logs any exception when obtaining the zone, but does not throw it as having the zone is only optional and should be non fatal to the logger.

coveralls · 2017-02-09T01:37:07Z

Changes Unknown when pulling 881e75f on jetty-project:enhance-zone into ** on GoogleCloudPlatform:master**.

coveralls · 2017-02-09T02:31:09Z

Changes Unknown when pulling b661c62 on jetty-project:enhance-zone into ** on GoogleCloudPlatform:master**.

coveralls · 2017-02-09T02:45:29Z

Changes Unknown when pulling 744ca64 on jetty-project:enhance-zone into ** on GoogleCloudPlatform:master**.

meltsufin · 2017-02-09T14:49:36Z

@garrettjonesgoogle Would this make into the next release, and when is it scheduled to go out?

Sign in to view

+      MonitoredResource resource = monitoredResource != null ? monitoredResource : getDefaultResource(resourceType);
+      writeOptions = new WriteOption[]{WriteOption.logName(logName), WriteOption.resource(resource)};
+    }
+    catch (Exception ex) {


Sign in to view

+    try {
+      HttpURLConnection metadata = (HttpURLConnection) new URL(
+          "http://metadata.google.internal/computeMetadata/v1/instance/zone").openConnection();
+      metadata.setRequestProperty("Metadata-Flavor", "Google");


garrettjonesgoogle · 2017-02-09T18:37:05Z

This should make it into the next release. I'm intending on doing a release tomorrow (Friday).

gregw · 2017-02-09T20:54:26Z

@garrettjonesgoogle I have fixed those issues. Note the unit tests are not passing, but neither are they in master (for me). I'll try to investigate later today.

garrettjonesgoogle · 2017-02-09T20:58:15Z

LGTM - once you figure out the tests I will merge it.

coveralls · 2017-02-09T23:21:40Z

Coverage decreased (-0.07%) to 83.382% when pulling b6100dd on jetty-project:enhance-zone into fa0720c on GoogleCloudPlatform:master.

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* fix: JSON parsing of S2A addresses. * extract extra parsing logic to calling method. * cast once + use defined constant.

* fix: JSON parsing of S2A addresses. * extract extra parsing logic to calling method. * cast once + use defined constant.

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…v3.48.0 (#1589)

…ncy-plugin to v3.6.0 (#1589)

* feat: Add FirestoreOpenTelemetryOptions to FirestoreOptions. (#1531) * feat: Add FirestoreOpenTelemetryOptions to FirestoreOptions. * Address code review feedback. * feat: Add com.google.cloud.firestore.telemetry package. (#1533) * feat: Add FirestoreOpenTelemetryOptions to FirestoreOptions. * feat: Add com.google.cloud.firestore.telemetry package. * Address code review feedback. * Factor out the otel version in pom.xml. * fix: Remove OpenCensus tracing code. (#1589) * feat: Add FirestoreOpenTelemetryOptions to FirestoreOptions. * feat: Add com.google.cloud.firestore.telemetry package. * fix: Remove OpenCensus tracing code. * feat: tracing for aggregate queries, bulkwriter, partition queries, a… (#1590) * feat: Add FirestoreOpenTelemetryOptions to FirestoreOptions. * feat: Add com.google.cloud.firestore.telemetry package. * fix: Remove OpenCensus tracing code. * feat: tracing for aggregate queries, bulkwriter, partition queries, and listDocuments. * Address code review feedback. * Address feedback. * don't use wildcard imports. * feat: trace instrumentation for DocumentReference methods. (#1591) * feat: Add FirestoreOpenTelemetryOptions to FirestoreOptions. * feat: Add com.google.cloud.firestore.telemetry package. * fix: Remove OpenCensus tracing code. * feat: tracing for aggregate queries, bulkwriter, partition queries, and listDocuments. * feat: trace instrumentation for DocumentReference methods. * feat: trace instrumentation for queries and transactions. (#1592) * feat: Add FirestoreOpenTelemetryOptions to FirestoreOptions. * feat: Add com.google.cloud.firestore.telemetry package. * fix: Remove OpenCensus tracing code. * feat: tracing for aggregate queries, bulkwriter, partition queries, and listDocuments. * feat: trace instrumentation for DocumentReference methods. * feat: trace instrumentation for queries and transactions. * test: Adding first e2e client-tracing test w/ Custom Root Span (#1621) * test: Adding first e2e client-tracing test w/ Custom Root Span * Roll back E2E tests commit. * Address feedback. * Address feedback (better event log message). * Address feedback. --------- Co-authored-by: Jimit J Shah <57637300+jimit-j-shah@users.noreply.github.com> * test: End-to-End Integration Test for Client-side Tracing in Firestore Java Server SDK using OpenTelemetry SDK and Cloud Trace Exporter against Cloud Trace. (#1635) * Adding first e2e client-tracing test w/ Custom Root Span * test: Adding first e2e client-tracing test w/ Custom Root Span * Fixing test dependencies and use default GCP testing project. Fixing * Fixing test dependencies and use default GCP testing project. * Fixing formatting * Add aggregationQueryGet Test * Add bulkWriterCommitTrace Test * Fixing running multiple-tests * Add partitionQuery Test * Add collectionListDocumentsTrace Test * Add docRef*Trace Tests * Add docRefUpdate*Trace and docRefDelete*Trace Tests * Fixing Trace fetching using retries for missing or incomplete traces due to eventual consistency of Cloud Trace * Add get/query Trace Tests * Add Transaction test * Added TraceContainer to be able to test transaction test-cases * test: Adding Transaction tests * test: Adding Transaction tests * test: Adding TestParameterInjector to run the test for global and non-global opentelemetry SDK instances * test: formatting and cleanup * test: Adding first e2e client-tracing test w/ Custom Root Span * test: Add aggregationQueryGet Test * test: Add bulkWriterCommitTrace Test and fixed running multiple-tests * test: Add partitionQuery Test * test: Add collectionListDocumentsTrace Test * test: Add docRefUpdate*Trace and docRefDelete*Trace Tests and fixed Trace fetching using retries for missing or incomplete traces due to eventual consistency of Cloud Trace * test: Add get/query Trace Tests * test: Added Transaction tests using TraceContainer to verify traces for Transaction ops (BeginTransaction, Rollback etc) * test: Adding TestParameterInjector to run the test for global and non-global opentelemetry SDK instances * test: Formatting and cleanup * test: review comments * test: fixing dfs to handle case where the compareTo callstack may be shorter than the trace callstack - don't need to throw an exception in that case * test: Consolidating verification methods * test: review comments * fix: Make telemetry-related fields transient. (#1638) * fix: Rename 'enabled' to 'tracingEnabled'. (#1639) * fix: Rename 'enabled' to 'tracingEnabled'. In the future, FirestoreOpenTelemetryOptions will support enabling/disabling Logging and Metrics as well. So we should use a better name for this field. * address feedback. * fix: Minor improvement to the ITE2ETracingTest. (#1637) * fix: Minor improvement to the ITE2ETracingTest. * revert the numExpectedSpans change. * feat: Add 'isTransactional' attribute. (#1657) * fix: Necessary test improvements for CI environments. (#1673) * fix: Necessary test improvements for CI environments. * Address feedback. * feat: Disable the tracing feature and remove public APIs. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Add the Firestore SDK version to the attributes. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update the "test" dependency versions. * Address feedback related to attributes. * Add 'project_id' attribute. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Revert a736fcc ("Disable the tracing feature and remove public APIs"). * GlobalOtel reset for test must happen in `before`, not `after`. * Address feedback. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Jimit J Shah <57637300+jimit-j-shah@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

add zone to GAE Flex logging enhancer

0fdd2ed

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 3, 2017

gregw mentioned this pull request Feb 3, 2017

Stackdriver logging #68 GoogleCloudPlatform/jetty-runtime#81

Merged

gregw added 3 commits February 3, 2017 13:52

remove unused imports

156c07c

avoid java8 API

d880c8c

remove unused imports

b7c062f

garrettjonesgoogle reviewed Feb 8, 2017

View reviewed changes

gregw added 4 commits February 9, 2017 10:44

Merge branch 'master' into enhance-zone

881e75f

public scope for Enhancer

ff35c4b

Updated metadata service header

744ca64

garrettjonesgoogle reviewed Feb 9, 2017

View reviewed changes

gregw added 3 commits February 10, 2017 07:49

Merge branch 'master' into enhance-zone

b0ec7f7

only TODO the metadata change

08c9963

Fixed format

b6100dd

garrettjonesgoogle merged commit c04d163 into googleapis:master Feb 9, 2017

gregw deleted the enhance-zone branch February 12, 2017 21:56

chingor13 pushed a commit that referenced this pull request Jan 22, 2026

chore(main): release 2.22.0 (#1589)

df9705b

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

chingor13 pushed a commit that referenced this pull request Jan 27, 2026

chore(main): release 0.132.22-alpha-SNAPSHOT (#1589)

01f6a88

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

chingor13 pushed a commit that referenced this pull request Feb 24, 2026

fix: JSON parsing of S2A addresses. (#1589)

9d5ebfe

* fix: JSON parsing of S2A addresses. * extract extra parsing logic to calling method. * cast once + use defined constant.

chingor13 pushed a commit that referenced this pull request Mar 12, 2026

fix: JSON parsing of S2A addresses. (#1589)

37adb15

* fix: JSON parsing of S2A addresses. * extract extra parsing logic to calling method. * cast once + use defined constant.

lqiu96 pushed a commit that referenced this pull request Mar 20, 2026

chore(main): release 0.132.22-alpha-SNAPSHOT (#1589)

c984c11

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026

chore(main): release 2.17.1 (googleapis#1589)

507b5cb

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

suztomo pushed a commit that referenced this pull request Mar 30, 2026

deps: update dependency com.google.cloud:sdk-platform-java-config to …

c6251b2

…v3.48.0 (#1589)

lqiu96 pushed a commit that referenced this pull request Apr 1, 2026

deps: update dependency com.google.cloud:sdk-platform-java-config to …

1ce789f

…v3.48.0 (#1589)

meltsufin pushed a commit that referenced this pull request Apr 29, 2026

build(deps): update dependency org.apache.maven.plugins:maven-depende…

07d65b7

…ncy-plugin to v3.6.0 (#1589)

meltsufin pushed a commit that referenced this pull request May 1, 2026

build(deps): update dependency org.apache.maven.plugins:maven-depende…

d20588c

…ncy-plugin to v3.6.0 (#1589)

Conversation

gregw commented Feb 3, 2017

Uh oh!

coveralls commented Feb 3, 2017

Uh oh!

coveralls commented Feb 3, 2017

Uh oh!

meltsufin commented Feb 6, 2017

Uh oh!

garrettjonesgoogle commented Feb 6, 2017

Uh oh!

garrettjonesgoogle left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Feb 9, 2017

Uh oh!

coveralls commented Feb 9, 2017

Uh oh!

coveralls commented Feb 9, 2017

Uh oh!

meltsufin commented Feb 9, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

garrettjonesgoogle commented Feb 9, 2017

Uh oh!

gregw commented Feb 9, 2017

Uh oh!

garrettjonesgoogle commented Feb 9, 2017

Uh oh!

coveralls commented Feb 9, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants