delete pull-related methods from PubSub by pongad · Pull Request #1487 · googleapis/google-cloud-java

pongad · 2016-12-21T01:58:38Z

Instead, provide a way to create the Subscriber object.

Sign in to view

-  }
-
  @Override
  public void modifyAckDeadline(String subscription, int deadline, TimeUnit unit, String ackId,


Sign in to view

-        .maxQueuedCallbacks(MAX_QUEUED_CALLBACKS.getInteger(optionMap))
-        .executorFactory(EXECUTOR_FACTORY.getExecutorFactory(optionMap))
+  public Subscriber subscriber(SubscriptionInfo subscription, Subscriber.MessageReceiver receiver) {
+    // TODO(pongad): Provide a way to pass in the rest of the options.


coveralls · 2016-12-21T02:58:10Z

Changes Unknown when pulling 9df40ba on pongad:del-pull into ** on GoogleCloudPlatform:pubsub-hp**.

pongad · 2016-12-21T03:20:47Z

@davidtorres PTAL

coveralls · 2016-12-21T03:54:41Z

Changes Unknown when pulling 2239a50 on pongad:del-pull into ** on GoogleCloudPlatform:pubsub-hp**.

coveralls · 2016-12-21T04:02:38Z

Changes Unknown when pulling 2239a50 on pongad:del-pull into ** on GoogleCloudPlatform:pubsub-hp**.

garrettjonesgoogle · 2016-12-21T23:29:03Z

A couple high-level things:

We need to write down in our TO DO list to write new samples that replace the deleted ones here (in spirit)
Does our new code have the same level of test coverage as the code that's being deleted?
We might want to write down some migration details for anyone using the library currently. Could you draft up a list of equivalents to each method on the main surface that you're deleting?

pongad · 2016-12-22T00:21:18Z

@garrettjonesgoogle

I made an issue for the TODO list: Tracking issue for PubSub high-perf client integration #1493
According to https://coveralls.io/builds/9371615, we have 80%+ on most classes. PollingSubscriberConnection is an exception at 76%. The missed lines are for expoenential backoff. They can be tested relatively easily I think.
The migration document is at google-cloud-pubsub/HP-MIGRATION.md, added to the last commit. There isn't that much to document, since the new surface is pretty small.

garrettjonesgoogle · 2016-12-22T01:04:33Z

Add a TODO to settle the issue of executors & channels. Otherwise LGTM.

coveralls · 2016-12-22T01:07:15Z

Changes Unknown when pulling 6cd3804 on pongad:del-pull into ** on GoogleCloudPlatform:pubsub-hp**.

coveralls · 2016-12-22T01:21:24Z

Changes Unknown when pulling 46bf12f on pongad:del-pull into ** on GoogleCloudPlatform:pubsub-hp**.

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

…v6.58.0 (googleapis#1487)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…-plugin to v3.5.0 (#1487) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-javadoc-plugin](https://maven.apache.org/plugins/) | `3.4.1` -> `3.5.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.5.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.5.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.5.0/compatibility-slim/3.4.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.5.0/confidence-slim/3.4.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-pubsub).

delete pull-related methods from PubSub

135a4b2

Instead, provide a way to create the Subscriber object.

pongad assigned garrettjonesgoogle Dec 21, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 21, 2016

davidtorres reviewed Dec 21, 2016

View reviewed changes

Comment thread google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/PubSubImpl.java Outdated

}

@Override

public void modifyAckDeadline(String subscription, int deadline, TimeUnit unit, String ackId,

This comment was marked as spam.

Sign in to view

pongad commented Dec 21, 2016

View reviewed changes

pongad added 2 commits December 21, 2016 13:20

fix typo

d7bda31

fix samples

9df40ba

pongad added 2 commits December 21, 2016 14:04

also delete modifyAckDeadline

c644775

google-java-format changed lines

2239a50

add migration doc

6cd3804

delete migration doc for now

46bf12f

pongad mentioned this pull request Dec 22, 2016

Tracking issue for PubSub high-perf client integration #1493

Closed

6 tasks

pongad merged commit 994479f into googleapis:pubsub-hp Dec 22, 2016

pongad deleted the del-pull branch December 22, 2016 01:17

suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026

deps: update dependency com.google.cloud:google-cloud-spanner-bom to …

e22529c

…v6.58.0 (googleapis#1487)

suztomo pushed a commit that referenced this pull request Mar 30, 2026

chore(main): release 0.127.25 (#1487)

7c3fa88

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

lqiu96 pushed a commit that referenced this pull request Apr 1, 2026

chore(main): release 0.127.25 (#1487)

57bd7e3

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

delete pull-related methods from PubSub#1487

delete pull-related methods from PubSub#1487
pongad merged 7 commits intogoogleapis:pubsub-hpfrom
pongad:del-pull

pongad commented Dec 21, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Dec 21, 2016

Uh oh!

pongad commented Dec 21, 2016

Uh oh!

coveralls commented Dec 21, 2016

Uh oh!

coveralls commented Dec 21, 2016

Uh oh!

garrettjonesgoogle commented Dec 21, 2016

Uh oh!

pongad commented Dec 22, 2016

Uh oh!

garrettjonesgoogle commented Dec 22, 2016

Uh oh!

coveralls commented Dec 22, 2016

Uh oh!

coveralls commented Dec 22, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

pongad commented Dec 21, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Dec 21, 2016

Uh oh!

pongad commented Dec 21, 2016

Uh oh!

coveralls commented Dec 21, 2016

Uh oh!

coveralls commented Dec 21, 2016

Uh oh!

garrettjonesgoogle commented Dec 21, 2016

Uh oh!

pongad commented Dec 22, 2016

Uh oh!

garrettjonesgoogle commented Dec 22, 2016

Uh oh!

coveralls commented Dec 22, 2016

Uh oh!

coveralls commented Dec 22, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants