feat(generator): emit callable getter and convenience method for resumable upload RPCs - #14319
Draft
whowes wants to merge 1 commit into
Draft
feat(generator): emit callable getter and convenience method for resumable upload RPCs#14319whowes wants to merge 1 commit into
whowes wants to merge 1 commit into
Conversation
whowes
added this pull request to stack #14327
September 9, 2026 06:35
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
whowes
force-pushed
the
whowes/generator-client-codegen
branch
from
September 9, 2026 15:50
a07c67a to
e0d1fe6
Compare
whowes
force-pushed
the
whowes/generator-client-codegen
branch
from
September 9, 2026 20:16
e0d1fe6 to
c202895
Compare
whowes
removed this pull request from stack #14327
September 9, 2026 23:45
whowes
added this pull request to stack #14343
September 9, 2026 23:47
whowes
force-pushed
the
whowes/generator-client-codegen
branch
2 times, most recently
from
September 10, 2026 00:19
39fdadf to
775a413
Compare
whowes
force-pushed
the
whowes/generator-client-codegen
branch
from
September 10, 2026 01:15
775a413 to
3c5beaf
Compare
whowes
force-pushed
the
whowes/generator-client-codegen
branch
from
September 10, 2026 06:05
3c5beaf to
9297723
Compare
whowes
force-pushed
the
whowes/generator-client-codegen
branch
from
September 11, 2026 17:23
9297723 to
5da1a23
Compare
whowes
removed this pull request from stack #14343
September 11, 2026 17:25
whowes
added this pull request to stack #14363
September 11, 2026 17:25
whowes
force-pushed
the
whowes/generator-client-codegen
branch
from
September 11, 2026 20:00
5da1a23 to
a885ba0
Compare
whowes
force-pushed
the
whowes/generator-client-codegen
branch
from
September 11, 2026 21:13
a885ba0 to
9215157
Compare
…mable upload RPCs - In AbstractServiceStubClassComposer: emit public ResumableUploadCallable<RequestT, ResponseT> [method]Callable() throwing UnsupportedOperationException - In AbstractServiceClientClassComposer: emit public ResumableUploadCallable<RequestT, ResponseT> [method]Callable() delegating to stub - In AbstractServiceClientClassComposer: emit synchronous convenience method [method](RequestT request, InputStream payload) calling ApiExceptions.callAndTranslateApiException - Suppress method variants (flattened methods) for resumable upload RPCs - In ServiceClientCommentComposer: emit Javadoc call context override warning on both callable method and synchronous convenience method - Add unit test ResumableUploadServiceClientComposerTest verifying generated stub and client methods
whowes
force-pushed
the
whowes/generator-client-codegen
branch
from
September 11, 2026 21:39
9215157 to
25824bd
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generates the public client surface and base stub contracts for resumable upload RPCs, providing both an asynchronous
ResumableUploadCallableand a synchronousInputStreammethod.Test composers are updated with placeholder
@Ignored tests to reflect that meaningful testing is only exercised via integration tests. This is due to insufficient mock capabilities, which may make sense to augment for resumable uploads in the future.Sample code generation for resumable uploads is disabled; this also probably makes sense to add in the future.