Skip to content

deps: move conscrypt from third-party-dependencies POM to gax-java POM - #13948

Merged
whowes merged 1 commit into
mainfrom
whowes/conscrypt-deps
Jul 29, 2026
Merged

deps: move conscrypt from third-party-dependencies POM to gax-java POM#13948
whowes merged 1 commit into
mainfrom
whowes/conscrypt-deps

Conversation

@whowes

@whowes whowes commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request moves the conscrypt-openjdk-uber dependency from third-party-dependencies/pom.xml to first-party-dependencies/pom.xml. There are no review comments, and I have no feedback to provide.

@whowes
whowes force-pushed the whowes/conscrypt-deps branch from fbfaef2 to fa9c9af Compare July 29, 2026 17:58
@whowes
whowes marked this pull request as ready for review July 29, 2026 18:02
@whowes
whowes requested review from a team as code owners July 29, 2026 18:02
@whowes
whowes requested a review from lqiu96 July 29, 2026 18:02
<version>2.73.0-SNAPSHOT</version><!-- {x-version-update:google-cloud-core:current} -->
<classifier>tests</classifier>
</dependency>
<dependency>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we manage it the same way as other core first party dependencies such as guava and protobuf? Add it to gax-parent should not need to specify the version again.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving to gax-parent seems to work - thanks for the pointer!

@whowes
whowes force-pushed the whowes/conscrypt-deps branch from fa9c9af to 636550a Compare July 29, 2026 18:36
@whowes whowes changed the title deps: switch conscrypt from third-party dep to first-party dep deps: move conscrypt from third-party-dependencies POM to gax-java POM Jul 29, 2026
@whowes
whowes requested a review from blakeli0 July 29, 2026 18:44
@whowes
whowes force-pushed the whowes/conscrypt-deps branch from 636550a to cbb8e94 Compare July 29, 2026 19:03
@sonarqubecloud

Copy link
Copy Markdown

@sonarqubecloud

Copy link
Copy Markdown

@whowes
whowes merged commit 1e634ec into main Jul 29, 2026
308 of 313 checks passed
@whowes
whowes deleted the whowes/conscrypt-deps branch July 29, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants