chore(bigquery-jdbc): refactor PreparedStatement and CallableStatement - #13849
Open
Neenu1995 wants to merge 58 commits into
Open
chore(bigquery-jdbc): refactor PreparedStatement and CallableStatement#13849Neenu1995 wants to merge 58 commits into
Neenu1995 wants to merge 58 commits into
Conversation
…d Calendar date setters
… CallableStatement
…yParameterMetaData
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…ryJdbcSqlFeatureNotSupportedException
…nsive copying across statement interfaces
…d-java into ps-part2-metadata
… in BigQueryTypeCoercionUtility
… and update CallableStatement and ResultSet to delegate to BigQueryTypeCoercionUtility
…rom BigQueryParameterHandler
…rom BigQueryParameterHandler and delegate directly to BigQueryTypeCoercionUtility
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…rameterHandlerTest to FieldValueTypeBigQueryCoercionUtilityTest
…r in BigQueryTypeCoercionUtility
…d-java into ps-part3-callable
…PreparedStatement
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors parameter handling in BigQueryCallableStatement and BigQueryPreparedStatement by standardizing parameter names, adding checkClosed() validation, and introducing helper methods like getRawParameter. Feedback on these changes highlights a few inconsistencies: BigQueryCallableStatement.setDate uses convertDateToCalendar instead of convertDateWithCalendar, the overloaded getObject methods are missing checkClosed() checks, and temporal types are handled inconsistently between BigQueryPreparedStatement (bound as strings) and BigQueryCallableStatement (bound as raw temporal objects).
Neenu1995
changed the title
logachev
reviewed
Jul 22, 2026
logachev
reviewed
Jul 22, 2026
logachev
reviewed
Jul 22, 2026
logachev
reviewed
Jul 24, 2026
| return null; | ||
| } | ||
| if (sqlType == StandardSQLTypeName.INT64 | ||
| && (parameterValue instanceof Short |
Contributor
There was a problem hiding this comment.
Why short/byte are special cased here?
| || parameterValue instanceof BigInteger)) { | ||
| return ((Number) parameterValue).longValue(); | ||
| } | ||
| if (sqlType == StandardSQLTypeName.FLOAT64 && parameterValue instanceof Float) { |
| public <T> T getObject(String parameterName, Class<T> type) throws SQLException { | ||
| checkClosed(); | ||
| return coerceValueToType( | ||
| getParameterAndTrackNull(parameterName), type, "'" + parameterName + "'"); |
Contributor
There was a problem hiding this comment.
Why quotes? I assume it is used in logger? if so, logger should add quotes
| public void registerOutParameter(int paramIndex, int sqlType) throws SQLException { | ||
| LOG.finer("registerOutParameter: paramIndex %s, sqlType %s", paramIndex, sqlType); | ||
| public void registerOutParameter(int parameterIndex, int sqlType) throws SQLException { | ||
| LOG.finer("registerOutParameter: parameterIndex %s, sqlType %s", parameterIndex, sqlType); |
logachev
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wasNull(): Routed all parameter getter paths inBigQueryCallableStatementthrough centralizedgetRawParameterhelpers, ensuring consistentwasNull()state tracking across all fast-path and fallback reads.checkClosed()checks to all implemented methods inBigQueryCallableStatementandBigQueryPreparedStatement.LOG.finerentry logging.getRef,getSQLXML) to directly throwBigQueryJdbcSqlFeatureNotSupportedException.