Skip to content

Un-shade javax#1362

Merged
mziccard merged 1 commit intogoogleapis:masterfrom
jean-philippe-martin:nio_unshade_javax
Nov 3, 2016
Merged

Un-shade javax#1362
mziccard merged 1 commit intogoogleapis:masterfrom
jean-philippe-martin:nio_unshade_javax

Conversation

@jean-philippe-martin
Copy link
Copy Markdown

@jean-philippe-martin jean-philippe-martin commented Nov 1, 2016

Shading javax was a mistake.

In addition we probably shouldn't be shading "provided" dependencies since those aren't included in the jar.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 1, 2016
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 1, 2016

Coverage Status

Coverage remained the same at 83.896% when pulling 848d810 on jean-philippe-martin:nio_unshade_javax into a963ef4 on GoogleCloudPlatform:master.

@mziccard mziccard merged commit a70747c into googleapis:master Nov 3, 2016
@jean-philippe-martin jean-philippe-martin deleted the nio_unshade_javax branch November 4, 2016 16:58
chingor13 pushed a commit that referenced this pull request Jan 6, 2026
@renovate-bot @gcf-owl-bot
deps: update dependency com.google.cloud:google-cloud-logging to v3.2…
9cf5174 
…0.1 (#1362)

* deps: update dependency com.google.cloud:google-cloud-logging to v3.20.1

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Feb 24, 2026
@aeitzman @lsirac
docs: adds docs for supplier based external account credentials (#1362)
bd898c6 
* docs: adds readme for supplier based external account credentials

* Update README.md

Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>

* Update README.md

Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>

* Update README.md

Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>

* Update README.md

Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>

* Update README.md

Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>

* Update README.md

Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>

* addressing review

* Addressing comments

* Apply suggestions from code review

Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>

* clean up workforce docs

* Addressing comments

* Apply suggestions from code review

Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>

* Adding audience documentation for workload

---------

Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 12, 2026
@aeitzman @lsirac
docs: adds docs for supplier based external account credentials (#1362)
a7b26e6 
* docs: adds readme for supplier based external account credentials

* Update README.md

Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>

* Update README.md

Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>

* Update README.md

Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>

* Update README.md

Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>

* Update README.md

Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>

* Update README.md

Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>

* addressing review

* Addressing comments

* Apply suggestions from code review

Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>

* clean up workforce docs

* Addressing comments

* Apply suggestions from code review

Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>

* Adding audience documentation for workload

---------

Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
@renovate-bot
build(deps): update dependency org.apache.maven.plugins:maven-shade-p…
c15cf3f 
…lugin to v3.5.1 (googleapis#1362)
suztomo pushed a commit that referenced this pull request Mar 30, 2026
@jean-philippe-martin @mziccard
Un-shade javax in google-cloud-nio shaded jar (#1362)
34056ac
suztomo pushed a commit that referenced this pull request Mar 30, 2026
@renovate-bot
test(deps): update dependency com.google.truth:truth to v1.4.1 (#1362)
c9601c0
lqiu96 pushed a commit that referenced this pull request Apr 1, 2026
@jean-philippe-martin @mziccard
Un-shade javax in google-cloud-nio shaded jar (#1362)
e7afddd
lqiu96 pushed a commit that referenced this pull request Apr 1, 2026
@renovate-bot
test(deps): update dependency com.google.truth:truth to v1.4.1 (#1362)
c09912d
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-shared-dependen…
d32c591 
…cies to v3.0.5 (#1362)
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
@release-please
chore(main): release 1.120.23 (#1367)
f1844eb 
🤖 I have created a release *beep* *boop*
---


## [1.120.23](https://togithub.com/googleapis/java-pubsub/compare/v1.120.22...v1.120.23) (2022-10-27)


### Dependencies

* Update dependency com.google.cloud:google-cloud-core to v2.8.22 ([#1361](https://togithub.com/googleapis/java-pubsub/issues/1361)) ([0355868](https://togithub.com/googleapis/java-pubsub/commit/03558680b9fb6493c2c3f1f4b65d8a35668b440f))
* Update dependency com.google.cloud:google-cloud-core to v2.8.24 ([#1368](https://togithub.com/googleapis/java-pubsub/issues/1368)) ([9776aad](https://togithub.com/googleapis/java-pubsub/commit/9776aad7391544b1e0bd2fbe8576180206943bef))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.5 ([#1362](https://togithub.com/googleapis/java-pubsub/issues/1362)) ([d32c591](https://togithub.com/googleapis/java-pubsub/commit/d32c591af87b66d8ca9df599ad18183aae31bf15))
* Update dependency com.google.protobuf:protobuf-java-util to v3.21.8 ([#1356](https://togithub.com/googleapis/java-pubsub/issues/1356)) ([dc1e0ca](https://togithub.com/googleapis/java-pubsub/commit/dc1e0ca44c3668d7c9e780d50261dd81ce1d4ee9))
* Update dependency org.easymock:easymock to v5.0.1 ([#1365](https://togithub.com/googleapis/java-pubsub/issues/1365)) ([2a807a5](https://togithub.com/googleapis/java-pubsub/commit/2a807a5b319ed3821da7dac84e4cb4923d07fed7))
* Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.16 ([#1358](https://togithub.com/googleapis/java-pubsub/issues/1358)) ([226e105](https://togithub.com/googleapis/java-pubsub/commit/226e1050b0b643cea46bad7cf77d2a9e8857fb02))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.16 ([#1359](https://togithub.com/googleapis/java-pubsub/issues/1359)) ([3f10227](https://togithub.com/googleapis/java-pubsub/commit/3f10227cfd7d9029e92e7575771544c7e4b4dd67))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
meltsufin pushed a commit that referenced this pull request May 1, 2026
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-shared-dependen…
c322328 
…cies to v3.0.5 (#1362)
meltsufin pushed a commit that referenced this pull request May 1, 2026
@release-please
chore(main): release 1.120.23 (#1367)
8dd53dd 
🤖 I have created a release *beep* *boop*
---


## [1.120.23](https://togithub.com/googleapis/java-pubsub/compare/v1.120.22...v1.120.23) (2022-10-27)


### Dependencies

* Update dependency com.google.cloud:google-cloud-core to v2.8.22 ([#1361](https://togithub.com/googleapis/java-pubsub/issues/1361)) ([e71dc8d](https://togithub.com/googleapis/java-pubsub/commit/e71dc8ddaaefd9856f1e05cd38c34562803b9470))
* Update dependency com.google.cloud:google-cloud-core to v2.8.24 ([#1368](https://togithub.com/googleapis/java-pubsub/issues/1368)) ([f85a1d1](https://togithub.com/googleapis/java-pubsub/commit/f85a1d1ba19ff97047de7ec2b5a0cd7f82a5c47a))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.5 ([#1362](https://togithub.com/googleapis/java-pubsub/issues/1362)) ([c322328](https://togithub.com/googleapis/java-pubsub/commit/c3223284d8c30b732a0a670a6cf388520c631ec5))
* Update dependency com.google.protobuf:protobuf-java-util to v3.21.8 ([#1356](https://togithub.com/googleapis/java-pubsub/issues/1356)) ([cfda245](https://togithub.com/googleapis/java-pubsub/commit/cfda2450976239e8fe55f6162b24155313f16194))
* Update dependency org.easymock:easymock to v5.0.1 ([#1365](https://togithub.com/googleapis/java-pubsub/issues/1365)) ([c70f5d8](https://togithub.com/googleapis/java-pubsub/commit/c70f5d81eff6982199585270a81ca80a5f0737c9))
* Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.16 ([#1358](https://togithub.com/googleapis/java-pubsub/issues/1358)) ([96160e1](https://togithub.com/googleapis/java-pubsub/commit/96160e1cd315efbbb634c2366e87a4f238c8888a))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.16 ([#1359](https://togithub.com/googleapis/java-pubsub/issues/1359)) ([243d233](https://togithub.com/googleapis/java-pubsub/commit/243d233d5530c8f5fc4964c36c700b0b80d99f82))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jean-philippe-martin @coveralls @mziccard @googlebot