chore: add markers in pom.xml#13271
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds generated dependency and module marker comments (such as <!-- {x-generated-dependencies-start} --> and <!-- {x-generated-dependencies-end} -->) to various pom.xml files across multiple Google Cloud Java client libraries. These markers are used to automate the management of generated dependencies and modules. I have no feedback to provide on these changes.
…tection, preventing them from being converted into broken tags fix lint
|
|
|
Closing this PR to reopen when generation for release is done to avoid repeating the work. |
1 participant
Add comment markers in pom.xml for generated proto and grpc artifacts.
These markers are added in parent, BOM and client pom.xml files for each library.
Also included in this PR is a one line fix for sdk-platform-java/hermetic_build/library_generation/owlbot/src/fix_poms.py, so that it ignores comments during extra module detection, and does not produce broken pom.xml files when the original has comments. 45f17c4.
The consequence of this minimal fix is that comments added will be wiped out when regenerated (see 557b1ed). This is acceptable as is only during migration and will re-run and add markers as needed.
For googleapis/librarian#6134