Skip to content

PubSub.listSubscriptions(topic) returns only names, not full subscriptions #978

Closed

Description

@mziccard

We need to change the signature of:

  • Page<Subscription> listSubscriptions(String topic, ListOption... options)
  • Future<AsyncPage<Subscription>> listSubscriptionsAsync(String topic, ListOption... options);

to:

  • Page<String> listSubscriptions(String topic, ListOption... options)
  • Future<AsyncPage<String>> listSubscriptionsAsync(String topic, ListOption... options);

As listing subscriptions by topic returns only names (see here). /cc @aozarov

Activity

  1. aozarov commented on May 3, 2016

    @aozarov
    Contributor

    /cc @eschapira Any reason for only returning the subscription names when one wants to get the list of subscriptions for a given topic?

  2. eschapira commented on May 4, 2016

    @eschapira

    The topic owner/viewer may not have access to the subscription details; but they can see the name of the subscriptions and delete those subscriptions.

    If we are using Subscription objects, as long as you don't need to fetch the details in order to instantiate it, meaning that you can instantiate a subscription object by just using the name, it should be fine to return the subscription object.

    It is important to keep in mind that these subscriptions may belong to a different project.

  3. mziccard commented on Jul 22, 2016

    @mziccard
    ContributorAuthor

    This was taken care of in #984

  4. added a commit that references this issue on Aug 9, 2022
  5. added a commit that references this issue on Mar 30, 2026
  6. added a commit that references this issue on Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: pubsubIssues related to the Pub/Sub API.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions