Skip to content

ListTopicSubscriptionsPagedResponse.iterateAllElements() should return Iterable<Subscription> #1668

Description

@jabubake

ListTopicSubscriptionsPagedResponse.iterateAllElements currently returns Iterable<String>.
It feels inconsistent with ListTopicsPagedResponse.iterateAllElements that returns Iterable<Topic>
and ListSubscriptionsPagedResponse.iterateAllElements returns Iterable<Subscription>.

Activity

  1. added
    type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.
    api: pubsubIssues related to the Pub/Sub API.
    on Feb 27, 2017
  2. changed the title [-]ListTopicSubscriptionsPagedResponse.iterateAllElements should return Iterable<Subscription>[/-] [+]`ListTopicSubscriptionsPagedResponse.iterateAllElements()` should return `Iterable<Subscription>`[/+] on Feb 27, 2017
  3. garrettjonesgoogle commented on Feb 27, 2017

    @garrettjonesgoogle
    Contributor

    This could get tricksy because of templating. Assigning to @michaelbausor to take a look at viability.

  4. garrettjonesgoogle commented on Jun 2, 2017

    @garrettjonesgoogle
    Contributor

    We now have a ListTopicSubscriptionsPagedResponse.iterateAllAsSubscriptionName method which returns Iterable<SubscriptionName>. I think this satisfies the issue.

    https://github.com/GoogleCloudPlatform/google-cloud-java/blob/d476ef7904467233e83168b8d1f5a934a0aae711/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/PagedResponseWrappers.java#L150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

api: pubsubIssues related to the Pub/Sub API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions