feat(bigtable): add view_parameters support to BoundStatement by ad548 · Pull Request #13673 · googleapis/google-cloud-java

ad548 · 2026-07-07T02:22:41Z

This PR ports the Java client changes supporting view_parameters in ExecuteQueryRequest (originally developed and reviewed internally in CL 13080 / branch add-view-parameters-support).

Changes

Added view_parameters support to BoundStatement and its builder.
Updated BoundStatementTest with unit tests for view_parameters.
Updated BoundStatementDeserializer in test-proxy to handle view_parameters.

Verification

Confirmed ExecuteQueryRequest in generated GAPIC proto library already contains view_parameters support.
Verified compilation and build across google-cloud-bigtable and dependencies.

gemini-code-assist

Code Review

This pull request adds support for view parameters in SQL BoundStatements, introducing the viewParameters field, builder methods to set them, and updating the proto serialization and test proxy deserializer. A review comment correctly points out that the newly added public method setViewParameter(String, Value) lacks direct unit test coverage and provides a helpful code suggestion to test this single-parameter setter.

We need to add support for `view_parameters` in the Java Bigtable client library and the Java Test Proxy to unblock Centigrate testing. Note that the backend Bigtable server currently only supports String typed view parameters. 1. In the Java client library (`BoundStatement.java`): - Update `BoundStatement` and its `Builder` to support storing `view_parameters`. - Implement runtime type validation in `setViewParameter` to check `value.getKindCase() == Value.KindCase.STRING_VALUE`, throwing an `IllegalArgumentException` if a non-String value is passed. - Update `BoundStatement.toProto()` to populate the `view_parameters` field in the `ExecuteQueryRequest` proto. 2. In the Java Test Proxy (`BoundStatementDeserializer.java`): - Update it to extract `view_parameters` from the incoming gRPC `ExecuteQueryRequest` and bind them to the `BoundStatement` before execution (naturally inheriting runtime type validation via delegation). 3. In `BoundStatementTest.java`: - Add unit test verifying `view_parameters` binding and proto conversion. - Add unit test `setViewParameterRejectsNonStringValues` verifying that passing non-String values (int64, bool, unset values, and array values) throws an `IllegalArgumentException`. Note: `bigtable.proto` in `google-cloud-java` already includes `view_parameters` in `ExecuteQueryRequest`. TAG=agy CONV=11853e8d-5cf0-4c6b-8917-b8d6dbac0814 Change-Id: Ie9fb8c3c19d077a99cb3164365752ff7273cbf51

Change-Id: I9fd4b13273004223d84cdb4df1678a26e851d412

…uilder Change-Id: I2183f39fa9b6197648c84f40eabab770096d6953

Change-Id: Ib5c71c01b359ac43e9ac68716020d6ab821ae7bd

…etStringViewParameter Change-Id: I56289a0414f766bd66db2894e06ae24564429744

… and update deserializer Change-Id: Iccfcdf792365a0c33cdd7383806593b31c7a5bfb

Change-Id: Ib27d1c22cf20ec7752681eab1fefbb181bbeb45e

…proxy module Change-Id: I5b8ac33ea5ef56ea087ecaebaf58857b401f531c

…izerTest Change-Id: Icf860414042548020a65d629862a43a601135afb

…cy analyze in CI Change-Id: I6bfc2a16b47797aed6145f785766883f4c21237b

mutianf · 2026-07-22T14:59:41Z

+      Value value = entry.getValue();
+      switch (value.getType().getKindCase()) {
+        case STRING_TYPE:
+          if (value.getKindCase().equals(KindCase.KIND_NOT_SET)) {


Is this right? The kindcase of null string is still string? https://github.com/googleapis/google-cloud-java/blob/main/java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/sql/BoundStatement.java#L213

I was following the query parameters pattern here https://github.com/ad548/google-cloud-java/blob/f051e2e08aa1306b10c5914fa90cfe34bf2e2920/java-bigtable/test-proxy/src/main/java/com/google/cloud/bigtable/testproxy/BoundStatementDeserializer.java#L50. There is two kindcase - value.getType().getKindCase() and value.getKindCase(). For view_parameters we definitely only care about the first. So yea null string with value.getType().getKindCase() string should be ok.

…tatement Change-Id: I17075aafac540e82501fddaeb5c6e5586fa9d7dc

…is-port-cl-13080 Change-Id: I743dab87f5fddfa338b45c84d2354791d7b933b6

…apis#13673) This PR ports the Java client changes supporting `view_parameters` in `ExecuteQueryRequest` (originally developed and reviewed internally in CL 13080 / branch `add-view-parameters-support`). ### Changes - Added `view_parameters` support to `BoundStatement` and its builder. - Updated `BoundStatementTest` with unit tests for `view_parameters`. - Updated `BoundStatementDeserializer` in test-proxy to handle `view_parameters`. ### Verification - Confirmed `ExecuteQueryRequest` in generated GAPIC proto library already contains `view_parameters` support. - Verified compilation and build across `google-cloud-bigtable` and dependencies.

🤖 I have created a release *beep* *boop* --- <details><summary>1.89.0</summary> ## [1.89.0](v1.88.0...v1.89.0) (2026-07-29) ### Features * **agentidentity:** onboard v1 and v1beta API versions ([#13796](#13796)) ([1b1300d](1b1300d)) * **auth:** add JSpecify Null annotations to Auth ([#13842](#13842)) ([f6f24d4](f6f24d4)) * **bigquery-jdbc:** add `SSLTrustStoreType` and `SSLTrustStoreProvider` connection properties ([#13858](#13858)) ([9449be1](9449be1)) * **bigquery-jdbc:** add otel trace and span IDs to local logs ([#13935](#13935)) ([2801fbd](2801fbd)) * **bigquery-jdbc:** implement BigQueryParameterMetaData and dynamic type mappings ([#13812](#13812)) ([3d67dba](3d67dba)) * **bigquery-jdbc:** implement parameter setters in PreparedStatement ([#13792](#13792)) ([94f7404](94f7404)) * **bigquery-jdbc:** Migrate `getImportedKeys` and `getCrossReference` to BQ API ([#13692](#13692)) ([082b046](082b046)) * **bigquery-jdbc:** migrate `getPrimaryKeys` to use BQ API ([#13691](#13691)) ([1951f49](1951f49)) * **bigquery-jdbc:** OpenTelemetry integration in BQ JDBC ([#12902](#12902)) ([af18f65](af18f65)) * **bigquery-jdbc:** optimize memory footprint for JSON result set streaming ([#13660](#13660)) ([11f26d3](11f26d3)) * **bigquery-jdbc:** standardize parameter handling and calendar defensive copying across statement interfaces ([#13805](#13805)) ([ccd13eb](ccd13eb)) * **bigtable:** add view_parameters support to BoundStatement ([#13673](#13673)) ([d5cc437](d5cc437)) * **bigtable:** BigtableDataClientFactory session support ([#13829](#13829)) ([284ce13](284ce13)) * **commerceproducer:** onboard v1beta API ([#13814](#13814)) ([61b89b3](61b89b3)) * Default to least-in-flight balancing for Bigtable unary clients ([#13802](#13802)) ([ac9ccd1](ac9ccd1)) * **firestore:** Add support for 16MB documents ([#13478](#13478)) ([1b7c2e0](1b7c2e0)) * **gapic-generator:** add JSpecify Null annotations to the generator classes ([#13769](#13769)) ([843bd7c](843bd7c)) * **gapic-generator:** Add Nullable annotation to generated classes ([#13558](#13558)) ([e3e9d0b](e3e9d0b)) * **gapic-generator:** Add NullMarked annotation to generated classes ([#13584](#13584)) ([b7a8504](b7a8504)) * **gax-httpjson:** Add Post Quantum Cryptography (PQC) Support by default via Conscrypt ([#13853](#13853)) ([550df81](550df81)) * **gax-java:** add JSpecify Null annotations to gax ([#13799](#13799)) ([65aee08](65aee08)) * **google/cloud/sql:** onboard a new library ([#13864](#13864)) ([38e272e](38e272e)) * **google/maps/navconnect/v1:** onboard a new library ([#13927](#13927)) ([2256394](2256394)) * **maps-isochrones:** onboard v1 API ([#13817](#13817)) ([3037ab3](3037ab3)) * port secure_context testing support to executor proxy ([#13522](#13522)) ([0f81bf0](0f81bf0)) * **productregistry:** onboard v1 API ([#13816](#13816)) ([9517313](9517313)) * **storage:** allow checksum on appendable upload finalization ([#13833](#13833)) ([ddf9add](ddf9add)) * **storage:** enable App-Centric Observability (ACO) support in Otel ([#13248](#13248)) ([4329896](4329896)) ### Bug Fixes * **bigquery-jdbc:** Add PerConnectionHandler to list of excempted logging classes ([#13888](#13888)) ([50b3c24](50b3c24)) * **bigquery-jdbc:** add preferIPv4Stack to argLine for Kokoro reliability ([#13923](#13923)) ([d5e33d6](d5e33d6)) * **bigquery-jdbc:** add service resource transformer for standalone IT ([#13893](#13893)) ([dc80fe8](dc80fe8)) * **bigquery-jdbc:** align metadata methods error handling with spec ([#13793](#13793)) ([d85fb10](d85fb10)) * **bigquery-jdbc:** fix WriteAPI when running in restricted environment ([#13856](#13856)) ([66ba925](66ba925)) * **bigquery-jdbc:** refine temporal timezone coercion and PreparedStatement parameter setters ([#13813](#13813)) ([6f68c4d](6f68c4d)) * **bigquery-jdbc:** resolve `ITOpenTelemetryTest` pipeline and trace validation failures ([#13898](#13898)) ([c18141d](c18141d)) * **bigquery-jdbc:** resolve failing otel IT in nightly ([#13915](#13915)) ([ac79713](ac79713)) * **bigquery:** resultSet.getLong() does not truncate for large int64 values ([#13718](#13718)) ([bc19822](bc19822)) * **bigquery:** support optional fields in BigLakeConfiguration to prevent NPE on Iceberg/Lakehouse tables ([#13733](#13733)) ([e2cca4d](e2cca4d)) * **bigtable:** add materialized view routing param to ReadRows and Sa… ([#13918](#13918)) ([4ddf250](4ddf250)) * **bigtable:** bound SessionPoolImpl lock to prevent pod-wide wedge ([#13890](#13890)) ([ed87a68](ed87a68)) * **bigtable:** fix session creation leaks ([#13887](#13887)) ([d586d07](d586d07)) * **bigtable:** prevent ClientConfigurationManagerTest from wedging on… ([#13907](#13907)) ([725086d](725086d)) * **bigtable:** stop installing DirectpathEnforcer on the directpath pool ([#13880](#13880)) ([5f2e056](5f2e056)) * **bom:** make release-note-generation Java 8 compatible ([#13837](#13837)) ([bc18390](bc18390)) * **ci:** fix java-cloud-bom release-notes workflow errors ([#13682](#13682)) ([b679835](b679835)) * deprecate resource detector ([#13844](#13844)) ([aba4f01](aba4f01)) * **deps:** align logback versions and add java8 profile in storage ([#13678](#13678)) ([7e57092](7e57092)) * do not start stream with direct executor ([#13945](#13945)) ([630e790](630e790)) * fix java-cloud-bom README update workflow after monorepo migration ([#13892](#13892)) ([5b8e295](5b8e295)) * **oauth2_http:** Avoid retrying on 4xx errors during GCE metadata ping ([#13715](#13715)) ([537c16c](537c16c)) * regenerate ([#13714](#13714)) ([8a72860](8a72860)) * regenerate libraries ([#13703](#13703)) ([a29ea79](a29ea79)), refs [#13690](#13690) * **release:** handle missing release tags gracefully in release-note-generation ([#13795](#13795)) ([43005fb](43005fb)) * **release:** resolve first-party-dependencies SNAPSHOT in libraries-bom ([#13790](#13790)) ([d5bfe21](d5bfe21)) * **spanner:** avoid data race on DIRECTPATH_CHANNEL_CREATED by using volatile ([#13727](#13727)) ([1e05ea5](1e05ea5)) * **spanner:** prevent fastpath tablet routing flaps ([#13803](#13803)) ([4dabdac](4dabdac)) * **storage:** BidiAppendableUpload Takeover operation fixes ([#13776](#13776)) ([f2d0474](f2d0474)) * **storage:** correctly insert explicit nulls for json patch updates ([#13716](#13716)) ([4fb3f4b](4fb3f4b)) * update group id mapping ([#13698](#13698)) ([50a72e1](50a72e1)) * use a new managed channel builder when creating channels ([#13684](#13684)) ([a049999](a049999)) ### Performance Improvements * **bigquery-jdbc:** optimize getExportedKeys performance using hybrid metadata lookup ([#13734](#13734)) ([c9738ea](c9738ea)) ### Dependencies * Add Conscrypt to shared-deps ([#13838](#13838)) ([05ce6ce](05ce6ce)) * move conscrypt from third-party-dependencies POM to gax-java POM ([#13948](#13948)) ([1e634ec](1e634ec)) * **shared-deps:** migrate awaitility to shared-dependencies ([#13671](#13671)) ([abb91ef](abb91ef)) * **shared-deps:** switch conscrypt shared dependency to conscrypt-openjdk-uber ([#13845](#13845)) ([2e3f208](2e3f208)) * Update gRPC-Java to v1.82.2 ([#13877](#13877)) ([da228d8](da228d8)) * Update http-client to v2.2.0 ([#13854](#13854)) ([334a2c5](334a2c5)) * Update Protobuf-Java to v4.33.6 ([#13876](#13876)) ([5c6478c](5c6478c)) * Upgrade Guava to v33.6.0-jre ([#13875](#13875)) ([41a7a52](41a7a52)) ### Documentation * add ErrorProne and NullAway integration guide and JSpecify migration playbook ([#13882](#13882)) ([d5ea739](d5ea739)) * add JSpecify nullness guidelines to AGENTS.md ([#13881](#13881)) ([54b846b](54b846b)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

ad548 requested review from a team as code owners July 7, 2026 02:22

gemini-code-assist Bot reviewed Jul 7, 2026

View reviewed changes

Comment thread ...-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/models/sql/BoundStatementTest.java

ad548 force-pushed the feat-view-parameters branch from 93f98fc to 198cc70 Compare July 16, 2026 22:18

style: apply google-java-format to BoundStatement and BoundStatementTest

79b16eb

Change-Id: I9fd4b13273004223d84cdb4df1678a26e851d412

mutianf reviewed Jul 17, 2026

View reviewed changes

ad548 added 7 commits July 17, 2026 20:14

refactor(bigtable): add setStringViewParameter(s) to BoundStatement.B…

1a170fc

…uilder Change-Id: I2183f39fa9b6197648c84f40eabab770096d6953

refactor(bigtable): address PR comments on view parameters API

c4c9e92

Change-Id: Ib5c71c01b359ac43e9ac68716020d6ab821ae7bd

refactor(bigtable): simplify setStringViewParameters to delegate to s…

7f20c89

…etStringViewParameter Change-Id: I56289a0414f766bd66db2894e06ae24564429744

docs(bigtable): add VIEW_PARAMETERS function calls comment to Javadoc…

6d10dc2

… and update deserializer Change-Id: Iccfcdf792365a0c33cdd7383806593b31c7a5bfb

test(bigtable): add BoundStatementDeserializerTest to test-proxy module

391c330

Change-Id: Ib27d1c22cf20ec7752681eab1fefbb181bbeb45e

fix(bigtable): add proto-google-cloud-bigtable-v2 dependency to test-…

8710442

…proxy module Change-Id: I5b8ac33ea5ef56ea087ecaebaf58857b401f531c

fix(bigtable): update copyright header year in BoundStatementDeserial…

328eb36

…izerTest Change-Id: Icf860414042548020a65d629862a43a601135afb

ad548 force-pushed the feat-view-parameters branch from 1f532a5 to 0e00636 Compare July 20, 2026 20:43

fix(bigtable): remove test-proxy from reactor modules to fix dependen…

2d15072

…cy analyze in CI Change-Id: I6bfc2a16b47797aed6145f785766883f4c21237b

ad548 force-pushed the feat-view-parameters branch from 0e00636 to 2d15072 Compare July 20, 2026 20:43

mutianf approved these changes Jul 22, 2026

View reviewed changes

mutianf reviewed Jul 22, 2026

View reviewed changes

Comment thread ...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/sql/BoundStatement.java Outdated

ad548 added 4 commits July 22, 2026 11:06

Merge branch 'main' into feat-view-parameters

f051e2e

refactor(bigtable): remove setViewParameters map overload from BoundS…

786c0d8

…tatement Change-Id: I17075aafac540e82501fddaeb5c6e5586fa9d7dc

Merge remote-tracking branch 'fork/feat-view-parameters' into synthes…

6565a3c

…is-port-cl-13080 Change-Id: I743dab87f5fddfa338b45c84d2354791d7b933b6

Merge branch 'main' into feat-view-parameters

ef58062

mutianf enabled auto-merge (squash) July 22, 2026 18:10

mutianf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 22, 2026

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 22, 2026

mutianf merged commit d5cc437 into googleapis:main Jul 22, 2026
209 of 212 checks passed

ad548 deleted the feat-view-parameters branch July 22, 2026 18:15

release-please Bot mentioned this pull request Jul 28, 2026

chore(main): release 1.89.0 #13934

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(bigtable): add view_parameters support to BoundStatement - #13673

feat(bigtable): add view_parameters support to BoundStatement#13673
mutianf merged 14 commits into
googleapis:mainfrom
ad548:feat-view-parameters

ad548 commented Jul 7, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mutianf Jul 22, 2026

Uh oh!

ad548 Jul 22, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ad548 commented Jul 7, 2026

Changes

Verification

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mutianf Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

ad548 Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants