Skip to content

fix(rest): enforce path encoding - #16580

Draft
wcornell wants to merge 2 commits into
googleapis:mainfrom
wcornell:fix-rest-path-encoding
Draft

wcornell wants to merge 2 commits into
googleapis:mainfrom
wcornell:fix-rest-path-encoding

Conversation

@wcornell

Copy link
Copy Markdown

Generated REST stubs previously constructed request URI paths with absl::StrCat, without percent-encoding path parameters or validating against . / .. traversal segments, unexpected / characters in single-segment fields, or malformed UTF-8.

  • Update internal::UrlEncode to strictly follow the RFC 3986 Section 2.3 unreserved character set
  • Add rest_internal::EncodePath / rest_internal::PathPiece to validate and encode single-segment, multi-segment (=**), and custom-verb (:verb) path components (returning StatusCode::kInvalidArgument on invalid inputs)
  • Update the generator and Discovery proto converter to emit EncodePath across all generated REST stubs.

The first commit contains all library, generator, golden, and test changes; the second commit contains only the regenerated Discovery .proto and *_rest_stub.cc files.

@wcornell wcornell changed the title Fix REST path encoding fix(rest): Enforce path encoding Oct 20, 2026
@wcornell wcornell changed the title fix(rest): Enforce path encoding fix(rest): enforce path encoding Oct 20, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors REST path construction across generated stubs by replacing absl::StrCat with rest_internal::EncodePath and rest_internal::PathPiece. This change ensures that path segments are safely encoded and validated, rejecting invalid segments containing . or .. with an argument error. The generator, along with its unit and integration tests, has been updated to support and verify this new path encoding behavior. I have no further feedback to provide as there are no review comments to assess.

@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.46939% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.43%. Comparing base (bca2305) to head (d1cbe43).

Files with missing lines Patch % Lines
...n_tests/golden/v1/internal/deprecated_rest_stub.cc 0.00% 3 Missing ⚠️
...s/golden/v1/internal/golden_rest_only_rest_stub.cc 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16580      +/-   ##
==========================================
+ Coverage   92.39%   92.43%   +0.03%     
==========================================
  Files        2266     2266              
  Lines      219636   220104     +468     
==========================================
+ Hits       202938   203447     +509     
+ Misses      16698    16657      -41     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch was successfully deployed

1 active deployment
false — d1cbe434 Deployed Oct 21, 2026 by wcornell via Save PR ref #12550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant