Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors REST path construction across generated stubs by replacing absl::StrCat with rest_internal::EncodePath and rest_internal::PathPiece. This change ensures that path segments are safely encoded and validated, rejecting invalid segments containing . or .. with an argument error. The generator, along with its unit and integration tests, has been updated to support and verify this new path encoding behavior. I have no further feedback to provide as there are no review comments to assess.
a52bd44 to
8534da2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16580 +/- ##
==========================================
+ Coverage 92.39% 92.43% +0.03%
==========================================
Files 2266 2266
Lines 219636 220104 +468
==========================================
+ Hits 202938 203447 +509
+ Misses 16698 16657 -41 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
8534da2 to
8fe6ee9
Compare
8fe6ee9 to
d1cbe43
Compare
Generated REST stubs previously constructed request URI paths with
absl::StrCat, without percent-encoding path parameters or validating against./..traversal segments, unexpected/characters in single-segment fields, or malformed UTF-8.internal::UrlEncodeto strictly follow the RFC 3986 Section 2.3 unreserved character setrest_internal::EncodePath/rest_internal::PathPieceto validate and encode single-segment, multi-segment (=**), and custom-verb (:verb) path components (returningStatusCode::kInvalidArgumenton invalid inputs)EncodePathacross all generated REST stubs.The first commit contains all library, generator, golden, and test changes; the second commit contains only the regenerated Discovery
.protoand*_rest_stub.ccfiles.